LinuxQuestions.org
Download your favorite Linux distribution at LQ ISO.
Home Forums Tutorials Articles Register
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices


Reply
  Search this Thread
Old 12-31-2016, 06:38 PM   #1
ljb643
Member
 
Registered: Nov 2003
Posts: 526

Rep: Reputation: Disabled
Patch for broken Lightning calendar color selector dialog


For some reason, the Lightning color selector dialogs do not work on my Slackware Linux PC with Seamonkey. The dialogs are used to set colors for categories and calendars. The dialogs open but do not respond to any keyboard or mouse input. I do not know if this affects all Slackware, or if it affects Thunderbird as well as Seamonkey. It wasn't working in Lightning-4.5b1 (for Seamonkey-2.40) and doesn't work in Lightning-5.1b1 (for Seamonkey-2.46).

There are some Mozilla bug reports on this, such as 1151440 and 1188945 but they are resolved. The problem was 'fixed' by special-casing Linux systems and doing something different with the dialogs. Unfortunately that doesn't work on my system because it falsely determines that it is not Linux (Application.platformIsLinux is not TRUE, for some reason).

As a quick fix I changed 2 script files in Lightning to insist that I have Linux. Inside the Lightning extension directory, the files are chrome/calendar/content/calendar/calUtils.js and chrome/calendar/content/calendar/preferences/categories.js and in 4 places it now just assumes Application.platformIsLinux is true. If anyone wants to try it, use patch -p0 from inside the Lightning extension directory - that is, extensions/{...} inside your Seamonkey profile directory.
Attached Files
File Type: txt lightning_color_dialog.patch.txt (3.0 KB, 11 views)
 
Old 01-01-2017, 10:08 AM   #2
bbuske
Member
 
Registered: Dec 2016
Location: Venezuela
Distribution: Manjaro
Posts: 109

Rep: Reputation: 15
Hello,

this looks like it has not been fixed then. I had heard a friend, who was playing around with Slackware mentioning something like this. However, he was not able to come up with a solution like you did and was thinking, that it was maybe just him.

It might be worth, to report a new bug or reply to one of the existing. Maybe has been fixed only for particular distributions and somehow the fix doesn't apply to Slackware. Also - probably a dumb question - but have you checked that the Slackware Package is updated to a version, that does contain that bug fix... You know, some distros take their time to update... that is if you got it from your distros repos in the first pace.

This said, thank you very much for sharing your patch. I will pass it on to my friend and see if it works for him as well.

Happy new year!
 
Old 01-01-2017, 04:45 PM   #3
ljb643
Member
 
Registered: Nov 2003
Posts: 526

Original Poster
Rep: Reputation: Disabled
Hi,

Thanks for the feedback. The first bug report I linked to was Resolved, Fixed with the change to Linux-specific behavior. That's the part the doesn't work for me. The second bug report I linked to is still open, but in that case the underlying issue seems to be different, because the test of "linux" seems to work there, but not for me.

I posted to their mailing list first, and since there has been no reply, I will do as you suggest and open or add to a bug report.
 
Old 01-01-2017, 04:49 PM   #4
ljb643
Member
 
Registered: Nov 2003
Posts: 526

Original Poster
Rep: Reputation: Disabled
Quote:
Originally Posted by bbuske View Post
Also - probably a dumb question - but have you checked that the Slackware Package is updated to a version, that does contain that bug fix... You know, some distros take their time to update... that is if you got it from your distros repos in the first pace.
I got my Lightning directly from addons.mozilla.org - I don't believe there is a Slackware package or slackbuilds.org entry for this.
 
Old 01-02-2017, 09:04 AM   #5
bbuske
Member
 
Registered: Dec 2016
Location: Venezuela
Distribution: Manjaro
Posts: 109

Rep: Reputation: 15
Ah ok... well in this case, I suppose you already got the latest version. The developers usually put it up way before it makes it into most of the repos.

From what you have mentioned though, it looks like it is a bug indeed. Might be something specific to Slackware or to your configuration or maybe someone just closed the bug too quickly. I have no experience with Slackware or with Mozilla, but I have been noticing quite a few times, where a bug I reported to KDE was marked as duplicate and respectively solved, even though the related bug was about a different (maybe similar, yet different) issue.

There is not much else I could think off.. and since you have come up with a temporary fix for you, I suppose you should be fine. Might be worth seeing if the next update will be fixing it.
 
Old 01-02-2017, 12:15 PM   #6
kikinovak
MLED Founder
 
Registered: Jun 2011
Location: Montpezat (South France)
Distribution: CentOS, OpenSUSE
Posts: 3,453

Rep: Reputation: 2154Reputation: 2154Reputation: 2154Reputation: 2154Reputation: 2154Reputation: 2154Reputation: 2154Reputation: 2154Reputation: 2154Reputation: 2154Reputation: 2154
As far as I know, Lightning is not an addon anymore, it's shipping with Thunderbird and can either be activated or deactivated.
 
Old 01-02-2017, 05:35 PM   #7
ljb643
Member
 
Registered: Nov 2003
Posts: 526

Original Poster
Rep: Reputation: Disabled
Lightning is bundled with Thunderbird, but not with Seamonkey. Seamonkey users can get Lightning from addons.mozilla.org . There was talk some time ago about bundling Lightning with Seamonkey, but I think they have had a lot of trouble with the Seamonkey builds and actually had to de-bundle some previously included extensions, so I think Lightning bundling is on hold.
 
  


Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off



Similar Threads
Thread Thread Starter Forum Replies Last Post
HOWTO: Google Calendar vs. Outllook & Evolution & Tbird Lightning SaintDanBert Linux - Software 5 10-29-2009 06:51 AM
Calendar in Incognito 2009.0 beta - Thunderbird/Lightning 0.9?? JamesBK Incognito 4 09-20-2009 02:10 PM
Help setting up a shared calendar using Lightning riderryuken Linux - Newbie 5 08-12-2009 10:22 AM
Integrating exchange calendar with Thunderbird and Lightning crimsonflame123 Linux - Software 0 07-15-2008 11:50 AM
Changing the file selector dialog in Mandriva 2005 beetlenaut Linux - Software 0 05-04-2005 04:42 AM

LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware

All times are GMT -5. The time now is 03:34 PM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
Open Source Consulting | Domain Registration