Patch for broken Lightning calendar color selector dialog
SlackwareThis Forum is for the discussion of Slackware Linux.
Notices
Welcome to LinuxQuestions.org, a friendly and active Linux Community.
You are currently viewing LQ as a guest. By joining our community you will have the ability to post topics, receive our newsletter, use the advanced search, subscribe to threads and access many other special features. Registration is quick, simple and absolutely free. Join our community today!
Note that registered members see fewer ads, and ContentLink is completely disabled once you log in.
If you have any problems with the registration process or your account login, please contact us. If you need to reset your password, click here.
Having a problem logging in? Please visit this page to clear all LQ-related cookies.
Get a virtual cloud desktop with the Linux distro that you want in less than five minutes with Shells! With over 10 pre-installed distros to choose from, the worry-free installation life is here! Whether you are a digital nomad or just looking for flexibility, Shells can put your Linux machine on the device that you want to use.
Exclusive for LQ members, get up to 45% off per month. Click here for more info.
Patch for broken Lightning calendar color selector dialog
For some reason, the Lightning color selector dialogs do not work on my Slackware Linux PC with Seamonkey. The dialogs are used to set colors for categories and calendars. The dialogs open but do not respond to any keyboard or mouse input. I do not know if this affects all Slackware, or if it affects Thunderbird as well as Seamonkey. It wasn't working in Lightning-4.5b1 (for Seamonkey-2.40) and doesn't work in Lightning-5.1b1 (for Seamonkey-2.46).
There are some Mozilla bug reports on this, such as 1151440 and 1188945 but they are resolved. The problem was 'fixed' by special-casing Linux systems and doing something different with the dialogs. Unfortunately that doesn't work on my system because it falsely determines that it is not Linux (Application.platformIsLinux is not TRUE, for some reason).
As a quick fix I changed 2 script files in Lightning to insist that I have Linux. Inside the Lightning extension directory, the files are chrome/calendar/content/calendar/calUtils.js and chrome/calendar/content/calendar/preferences/categories.js and in 4 places it now just assumes Application.platformIsLinux is true. If anyone wants to try it, use patch -p0 from inside the Lightning extension directory - that is, extensions/{...} inside your Seamonkey profile directory.
this looks like it has not been fixed then. I had heard a friend, who was playing around with Slackware mentioning something like this. However, he was not able to come up with a solution like you did and was thinking, that it was maybe just him.
It might be worth, to report a new bug or reply to one of the existing. Maybe has been fixed only for particular distributions and somehow the fix doesn't apply to Slackware. Also - probably a dumb question - but have you checked that the Slackware Package is updated to a version, that does contain that bug fix... You know, some distros take their time to update... that is if you got it from your distros repos in the first pace.
This said, thank you very much for sharing your patch. I will pass it on to my friend and see if it works for him as well.
Thanks for the feedback. The first bug report I linked to was Resolved, Fixed with the change to Linux-specific behavior. That's the part the doesn't work for me. The second bug report I linked to is still open, but in that case the underlying issue seems to be different, because the test of "linux" seems to work there, but not for me.
I posted to their mailing list first, and since there has been no reply, I will do as you suggest and open or add to a bug report.
Also - probably a dumb question - but have you checked that the Slackware Package is updated to a version, that does contain that bug fix... You know, some distros take their time to update... that is if you got it from your distros repos in the first pace.
I got my Lightning directly from addons.mozilla.org - I don't believe there is a Slackware package or slackbuilds.org entry for this.
Ah ok... well in this case, I suppose you already got the latest version. The developers usually put it up way before it makes it into most of the repos.
From what you have mentioned though, it looks like it is a bug indeed. Might be something specific to Slackware or to your configuration or maybe someone just closed the bug too quickly. I have no experience with Slackware or with Mozilla, but I have been noticing quite a few times, where a bug I reported to KDE was marked as duplicate and respectively solved, even though the related bug was about a different (maybe similar, yet different) issue.
There is not much else I could think off.. and since you have come up with a temporary fix for you, I suppose you should be fine. Might be worth seeing if the next update will be fixing it.
Lightning is bundled with Thunderbird, but not with Seamonkey. Seamonkey users can get Lightning from addons.mozilla.org . There was talk some time ago about bundling Lightning with Seamonkey, but I think they have had a lot of trouble with the Seamonkey builds and actually had to de-bundle some previously included extensions, so I think Lightning bundling is on hold.
LinuxQuestions.org is looking for people interested in writing
Editorials, Articles, Reviews, and more. If you'd like to contribute
content, let us know.