it's -current time! (+pssh small bug)

ponce · 06-19-2010, 02:51 AM

http://slackware.com/changelog/current.php?cpu=x86_64

the -current branch is on the loose!

I take the opportunity to point out a small bug I wrote about Pat two weeks ago (probably he has a very busy mailbox

) that interests pssh users (I hope someone here can report him in a better way):

Code:

$ pssh
Traceback (most recent call last):
  File "/usr/bin/pssh", line 23, in <module>
    from psshlib import psshutil
ImportError: No module named psshlib

had a look at the slackbuild and changing this two lines

Code:

mkdir -p $PKG/$PREFIX/lib${LIBDIRSUFFIX}
cp -a psshlib $PKG/$PREFIX/lib${LIBDIRSUFFIX}/.

with

Code:

mkdir -p $PKG/$PREFIX/lib${LIBDIRSUFFIX}/python2.6
cp -a psshlib $PKG/$PREFIX/lib${LIBDIRSUFFIX}/python2.6/.

seems to fix things.

thanks to Pat and the slackware people for the new -current!
now I have my favourite playground.

GazL · 06-19-2010, 05:42 AM

From experience I can say that though Pat often doesn't write back to you, your patches will show up eventually. With a couple of mine last cycle it was a couple of months before they showed up. I suspect Pat puts some of the mail he gets in a when-I-get-around-to-it folder. It's a bit off-putting when you don't get a response to your mail but I imagine the poor guy's inbox is overflowing most mornings so I don't hold it against him.

ponce · 06-19-2010, 10:18 AM

yes, no prob at all for me

just pointing it out for any other pssh user

fskmh · 06-19-2010, 12:32 PM

I would suggest replacing the static version info with something more abstract. After fiddling with python -V, python -c "import sys; print sys.path.lib" and python-config, I came up with this diff for pssh.SlackBuild:

Code:

--- pssh.SlackBuild     2010-06-19 19:28:29.000000000 +0200
+++ pssh.SlackBuild     2010-06-19 19:30:04.000000000 +0200
@@ -23,7 +23,7 @@
 # required: package "python" version 2.2 or higher installed
 
 VERSION=2.1.1
-BUILD=1
+BUILD=2
 
 # Note that the package will be created as 'noarch' !
 # Automatically determine the architecture we're building on:
@@ -44,6 +44,12 @@
   LIBDIRSUFFIX=""
 fi
 
+PYMAJOR=`python-config --libs | awk -Fpython '{print $2}'`
+if [ -z ${PYMAJOR} ]; then
+  echo "Could not determine major version of Python - bailing."
+  exit 1
+fi
+
 CWD=$(pwd)
 TMP=${TMP:-/tmp}
 PKG=$TMP/package-pssh
@@ -77,8 +83,8 @@
   touch ${library}c
 done
 
-mkdir -p $PKG/$PREFIX/lib${LIBDIRSUFFIX}
-cp -a psshlib $PKG/$PREFIX/lib${LIBDIRSUFFIX}/.
+mkdir -p $PKG/$PREFIX/lib${LIBDIRSUFFIX}/python${PYMAJOR}
+cp -a psshlib $PKG/$PREFIX/lib${LIBDIRSUFFIX}/python${PYMAJOR}/.
 
 mkdir -p $PKG/$PREFIX/doc/pssh-$VERSION
 cp -a \

Alien Bob · 06-19-2010, 04:22 PM

Determining the version of python is as simple as calling:

Code:

python -c 'import sys; print sys.version[:3]'

Eric

fskmh · 06-19-2010, 04:52 PM

Ah now that's the better method I was fiddling around to try and find. Thanks.