Has anyone a build script for i8kutils (tools for Dell notebooks fan control)? I've found this one, what do you think? https://github.com/cycojesus/slackbu...ils.SlackBuild
it's a curious script, all in one stuff using with that here tag for input to cat.. i wouldnt do it like this, considering it's for a buildscript and sbo && slackware have a similar standard that is not this!
aside from that it looks fine
/* personally i would just rip stuff out from this and write teh buildscript myself, finally submit it to sbo if i was in need of this. */
a good rule of thumb is simply comparing to other build scripts, anything really:
i don't know why it isent taking advantage of the install clp for the makefile, since as your buildscript shows me the src also supports the DESTDIR variable.. it would make stuff and things "duhhhh" less thinking!!
it might of gave a bad example but in general stuff like this helps confirm and reduces questions!
I finally ended up with a (SBo-like) SlackBuild for i8kutils.
You can find it at https://github.com/sanjioh/slackbuild-i8kutils
It seems to be working fine here (Inspiron SE, aka 7520), I'm just planning to improve the rc.i8kmon script a little.
I've submitted the current version to SBo, it's pending for approval.
Bug reports, pull requests and testing in general are welcome! :)
|All times are GMT -5. The time now is 01:40 AM.|