LinuxQuestions.org
View the Most Wanted LQ Wiki articles.
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices



Reply
 
Search this Thread
Old 04-12-2014, 06:50 PM   #16
j_v
Member
 
Registered: Oct 2011
Distribution: Slackware64, LFS, Crux
Posts: 207

Rep: Reputation: 31

@Alien Bob: I was wondering how your package worked and not home built ones. At first, I concidered that maybe you had some special CFLAGS in your environment, but that seemed far fetched. I read your slackbuild, and could not find a major difference that told me: "Ah, this is where he fixes the issue!" Thanks for your input and insight.

Cheers,
John

EDIT: rereading this now, it sounds like I am asking a question, but it is just me having an "aha" moment about the difference it made (re: resulting in usable binaries) that you compiled with gcc-4.7.

Last edited by j_v; 04-12-2014 at 08:54 PM. Reason: recapitulate
 
Old 04-12-2014, 08:32 PM   #17
moisespedro
Senior Member
 
Registered: Nov 2013
Location: Brazil
Distribution: Slackware
Posts: 1,139

Original Poster
Rep: Reputation: 151Reputation: 151
Quote:
Originally Posted by Alien Bob View Post
Are you sure the build used that newer tarball? Handbrake downloads a very specific version of x264 which is hardcoded in the build script. All my SlackBuild script does is download it beforehand, so that you can do an offline build of the package.
Check your build log (you kept a log did you?) and find out if a x264 tarball was downloaded before the compilation started.

Eric
Yes, I am sure the newer tarball was used. I removed the old one, the new one was downloaded, extracted and then used. No, I don't have a log. I am still getting the hang of this stuff so I am kinda disorganized.
 
Old 04-13-2014, 06:05 AM   #18
Alien Bob
Slackware Contributor
 
Registered: Sep 2005
Location: Eindhoven, The Netherlands
Distribution: Slackware
Posts: 5,383

Rep: Reputation: Disabled
Quote:
Originally Posted by moisespedro View Post
Yes, I am sure the newer tarball was used. I removed the old one, the new one was downloaded, extracted and then used. No, I don't have a log. I am still getting the hang of this stuff so I am kinda disorganized.
I applied the diff you posted earlier on (that changes the version and the download URL of the x264 source tarball) and ran a build. This is what I find in the log file:

Code:
...

  : /usr/bin/wget -O ../download/x264-r2273-b3065e6.tar.gz http://download.handbrake.fr/handbrake/contrib/x264-r2273-b3065e6.tar.gz
  : /usr/bin/mkdir -p contrib/x264/
  : /usr/bin/mkdir -p contrib/libbluray/
  : --2014-04-13 11:34:41--  http://download.handbrake.fr/handbrake/contrib/x264-r2273-b3065e6.tar.gz
  : Resolving download.handbrake.fr (download.handbrake.fr)... /usr/bin/mkdir -p test/

...

  : Connecting to download.handbrake.fr (download.handbrake.fr)|88.190.242.142|:80... connected.
  : HTTP request sent, awaiting response... 200 OK
  : Length: 681489 (666K) [text/plain]
  : Saving to: '../download/x264-r2273-b3065e6.tar.gz'
  : 
  :      0K .......... .......... .......... .......... ..........  7%  508K 1s
  :     50K .......... .......... .......... .......... .......... 15%  833K 1s
  :    100K .......... .......... .......... .......... .......... 22% 1.02M 1s
  :    150K .......... .......... .......... .......... .......... 30%  955K 1s
  :    200K .......... .......... .......... .......... .......... 37%  958K 1s
  :    250K .......... .......... .......... .......... .......... 45% 1011K 0s
  :    300K .......... .......... .......... .......... .......... 52% 1.29M 0s
  :    350K .......... .......... .......... .......... .......... 60%  807K 0s
  :    400K .......... .......... .......... .......... .......... 67% 1.39M 0s
  :    450K .......... .......... .......... .......... .......... 75% 1.33M 0s
  :    500K .......... .......... .......... .......... .......... 82%  912K 0s
  :    550K .......... .......... .......... .......... .......... 90% 1.24M 0s
  :    600K .......... .......... .......... .......... .......... 97%  830K 0s
  :    650K .......... .....                                      100% 6.16M=0.7s
  : 
  : 2014-04-13 11:34:42 (966 KB/s) - '../download/x264-r2273-b3065e6.tar.gz' saved [681489/681489]

...

  : /usr/bin/tar xfC ../download/x264-r2273-b3065e6.tar.gz ./contrib/x264/
  : touch contrib/x264/.stamp.extract

...
... meaning your newer x264 source is never used, and the handbrake Makefile still downloads the version it has hardcoded.
It is always a good idea to log your compilation process, or even the output of any long-running process which fills more than one screen.

Eric
 
Old 04-13-2014, 06:39 AM   #19
moisespedro
Senior Member
 
Registered: Nov 2013
Location: Brazil
Distribution: Slackware
Posts: 1,139

Original Poster
Rep: Reputation: 151Reputation: 151
Oh, my mistake then. I apologize.
 
Old 04-13-2014, 07:05 AM   #20
ponce
Senior Member
 
Registered: Aug 2004
Location: Pisa, Italy
Distribution: Slackware
Posts: 2,498

Rep: Reputation: 912Reputation: 912Reputation: 912Reputation: 912Reputation: 912Reputation: 912Reputation: 912Reputation: 912
if feel like testing it, now that I know the cause (thanks Eric!) I created a patch to apply to the Slackbuild on SBo: it updates x264 to the latest snapshot tarball
Code:
diff -Naur HandBrake.orig/HandBrake.SlackBuild HandBrake/HandBrake.SlackBuild
--- HandBrake.orig/HandBrake.SlackBuild 2014-03-25 17:46:03.408351684 +0100
+++ HandBrake/HandBrake.SlackBuild      2014-04-13 12:50:13.664933681 +0200
@@ -5,10 +5,11 @@
 # This slackbuild maintained by Klaatu at klaatu@hackerpublicradio.org
 # Modified by David Somero at SlackBuilds.org.
 # Modified by Erik Hanson at SlackBuilds.org
+# Modified by Matteo Bernardini at SlackBuilds.org
 
 PRGNAM=HandBrake
 VERSION=${VERSION:-0.9.9}
-BUILD=${BUILD:-1}
+BUILD=${BUILD:-2}
 TAG=${TAG:-_SBo}
 
 if [ -z "$ARCH" ]; then
@@ -47,10 +48,19 @@
 chown -R root:root .
 find -L . \
  \( -perm 777 -o -perm 775 -o -perm 750 -o -perm 711 -o -perm 555 \
-  -o -perm 511 \) -exec chmod 755 {} \; -o \
+ -o -perm 511 \) -exec chmod 755 {} \; -o \
  \( -perm 666 -o -perm 664 -o -perm 640 -o -perm 600 -o -perm 444 \
  -o -perm 440 -o -perm 400 \) -exec chmod 644 {} \;
 
+# Update to a more recent x264 to avoid segfaults
+sed -i \
+  -e "s|\ 130$| 142|" \
+  -e "s|r2273\ b3065e6|r2273 aff928d|" \
+  contrib/x264/A00-version-string.patch || exit 1
+sed -i \
+  "s|^X264\.FETCH\.url.*|X264.FETCH.url = http://ponce.cc/slackware/sources/repo/x264-r2273_aff928d.tar.bz2|" \
+  contrib/x264/module.defs || exit 1
+
 ./configure \
   --prefix=/usr \
   --disable-gtk-update-checks \
diff -Naur HandBrake.orig/HandBrake.info HandBrake/HandBrake.info
--- HandBrake.orig/HandBrake.info       2014-03-25 17:46:03.408351684 +0100
+++ HandBrake/HandBrake.info    2014-04-13 12:51:20.511933681 +0200
@@ -25,7 +25,7 @@
           http://mp4v2.googlecode.com/files/mp4v2-trunk-r355.tar.bz2 \
           http://download.m0k.org/handbrake/contrib/mpeg2dec-0.5.1.tar.gz \
           http://download.m0k.org/handbrake/contrib/pthreads-w32-cvs20100909.tar.bz2 \
-          http://download.handbrake.fr/handbrake/contrib/x264-r2273-b3065e6.tar.gz \
+          http://ponce.cc/slackware/sources/repo/x264-r2273_aff928d.tar.bz2 \
           http://download.m0k.org/handbrake/contrib/zlib-1.2.3.tar.gz"
 MD5SUM="ee81337a46f8af76599d6038f193a2c1 \
         ce5a978bb359f642dcbd24c6e14a45a7 \
@@ -51,7 +51,7 @@
         38a753e936df5ef4c2f7de3d16f440f6 \
         a6173dc90cfe7f0414624c3c8bbad727 \
         d1dea735b53176567e9841ca77388633 \
-        10a0f3307027f2d8321f4d834e319208 \
+        95a848eddf84a4c3ba6477d7f365ff63 \
         af3358a811ad3469a2e54db49f77d52a"
 DOWNLOAD_x86_64=""
 MD5SUM_x86_64=""
 
Old 04-13-2014, 09:37 AM   #21
j_v
Member
 
Registered: Oct 2011
Distribution: Slackware64, LFS, Crux
Posts: 207

Rep: Reputation: 31
@ponce: I've tested your patch and it works good for me.

Last edited by j_v; 04-13-2014 at 09:41 AM.
 
  


Reply


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
alien's vlc, -current and SBo's libva grissiom Slackware 2 10-28-2010 09:50 AM
segmentation faults crash88 Linux - Software 3 07-03-2006 11:22 PM
Segmentation faults winterhunter Linux - Software 5 10-14-2005 04:06 AM
Some help with segmentation faults? captainslushie Linux - Software 5 06-23-2005 03:59 PM
Segmentation Faults ryankask Mandriva 2 06-13-2005 08:10 PM


All times are GMT -5. The time now is 09:44 AM.

Main Menu
Advertisement
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
identi.ca: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration