freetype.slackbuild This breaks too many things

arubin · 10-18-2007, 03:47 PM

freetype.slackbuild has the following

# This breaks far too many things. Freetype2 developers will have to get their
# punishment on someone else's distribution.
zcat $CWD/freetype.illadvisederror.diff.gz | patch -p1 --verbose || exit 1

Should this line be commented out or not?

Thanks

Alien Bob · 10-18-2007, 03:50 PM

Why do you think Pat leaves it in you think? Did you look at the content of the patch?

Eric

rworkman · 10-18-2007, 03:55 PM

Did you actually read the patch?

Code:

diff -u -r freetype-2.1.7.orig/include/freetype/freetype.h freetype-2.1.7/include/freetype/freetype.h
--- freetype-2.1.7.orig/include/freetype/freetype.h     2003-11-09 00:38:13.000000000 -0800
+++ freetype-2.1.7/include/freetype/freetype.h  2004-06-05 13:43:55.000000000 -0700
@@ -16,13 +16,20 @@
 /***************************************************************************/
 
 
-#ifndef FT_FREETYPE_H
-#error "`ft2build.h' hasn't been included yet!"
-#error "Please always use macros to include FreeType header files."
-#error "Example:"
-#error "  #include <ft2build.h>"
-#error "  #include FT_FREETYPE_H"
-#endif
+/***************************************************************************/
+/*                                                                         */
+/* If you think breaking almost 100% of all source that links with         */
+/* freetype (anything using a configure file for sure) is a good idea,     */
+/* then feel free to uncomment this block.                                 */
+/*                                                                         */
+/* #ifndef FT_FREETYPE_H                                                   */
+/* #error "`ft2build.h' hasn't been included yet!"                         */
+/* #error "Please always use macros to include FreeType header files."     */
+/* #error "Example:"                                                       */
+/* #error "  #include <ft2build.h>"                                        */
+/* #error "  #include FT_FREETYPE_H"                                       */
+/* #endif                                                                  */
+/***************************************************************************/
 
 
 #ifndef __FREETYPE_H__

rworkman · 10-18-2007, 03:56 PM

Heh. Well, perhaps I should have refreshed the page before clicking "submit" ;-)

arubin · 10-18-2007, 03:58 PM

I think it would be nice to be able to manage slackware without being a C programmer.

Ok. I have read it. I am really not stupid. I still do not know the answer to the question.

Alien Bob · 10-18-2007, 04:01 PM

You want to know if that patch should be left out, yet you don't want to look into the why?
In that case why don't you just trust the judgement of Patrick Volkerding? Leave that package alone.

Eric

Edit: or better - kill the patch, rebuild the package, and then rebuild one or more of the packages that link against freetype2 (there are many in Slackware, and more at http://SlackBuilds.org). This would be more instructive than my (somewhat) harsh original comment...

arubin · 10-18-2007, 04:07 PM

What I am trying to find out is what Pat's judgment is on this. As you know there are a couple of other lines in the slackbuild that can be commented out.

I just found lines
# This breaks far too many things. Freetype2 developers will have to get their
# punishment on someone else's distribution.

ambiguous

What is it with you guys? You are usually so helpful.

Alien Bob · 10-18-2007, 04:13 PM

I don't like to point out the obvious nor to spend time on something useless.

It means what it says: the default freetype build will break many other pieces of software that link against freetype.. i.e. they will fail at the configure step.

Pat includes this literal text which I can not improve on:

Quote:

If you think breaking almost 100% of all source that links with freetype (anything using a configure file for sure) is a good idea, then feel free to uncomment this block.

Eric

arubin · 10-18-2007, 04:17 PM

You have to know that the line in the slack.build refers to the patch to get that far which I did not.

Alien Bob · 10-18-2007, 04:25 PM

It just dawned on me what your problem may be with that comment in the SlackBuild... you thought that leaving the line in would break things?
In that case, we had a dysfunctional conversation here... the patch fixes the breakage.

Eric

arubin · 10-18-2007, 04:33 PM

Exactly. :-)