LinuxQuestions.org
Visit the LQ Articles and Editorials section
Go Back   LinuxQuestions.org > Forums > Linux Forums > Linux - Distributions > Slackware
User Name
Password
Slackware This Forum is for the discussion of Slackware Linux.

Notices

Reply
 
Search this Thread
Old 04-17-2011, 10:22 AM   #1
_GArik_
LQ Newbie
 
Registered: Nov 2010
Posts: 19

Rep: Reputation: 6
bash-completion package needs testing


Hi, all. There are bash completion scripts for various slackware related tools -- pkgtools, rpm2tgz, sbopkg, slackpkg, slapt-get / slapt-src. All this completions are more or less tested, but some bugs can still remain as I don't actually use all listed tools. Please grab package here and test it thoroughly: bash-completion-1.3-noarch-2ga.txz. Feel free to report any concerns in this thread or on github.
 
Old 04-17-2011, 10:37 AM   #2
bmn
LQ Newbie
 
Registered: May 2009
Posts: 15

Rep: Reputation: 0
Thanks for post it.
Note: sbopkg completion script now included to sbopkg package.
 
Old 04-17-2011, 04:00 PM   #3
slakmagik
Senior Member
 
Registered: Feb 2003
Distribution: Slackware
Posts: 4,113

Rep: Reputation: Disabled
Quote:
Originally Posted by bmn View Post
Note: sbopkg completion script now included to sbopkg package.
_GArik_'s is, IIUC, a full bash-completion setup which has been forked from the alioth completion project to provide the additional Slackware completions. What's provided in sbopkg (or, rather, will be some sunny day in the far future when Slackware/SBo open their new stable branches and a new sbopkg can be released to go with them) was split off from _GArik_'s by Sergey V. so that it's a stand-alone completion file. (IOW, you don't need to install anything not included in a stock Slackware for all files in sbopkg to work.) Which you use is entirely up to you (depending on whether you want to add the full completion package or use something more app-specfic), but they're different.
 
Old 04-17-2011, 06:25 PM   #4
rworkman
Slackware Contributor
 
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 1,913

Rep: Reputation: Disabled
Are the versions of the pkgtool, slapt-get, sbopkg, and slackpkg completion stubs different than the ones we put in the /usr/doc/bash-completion-1.3/contrib/ directory?

Regardless of the answer to that, I think I better idea is to provide *only* the changed completion files, and instruct potential testers to place them in /etc/bash_completion.d/, and then do ". /etc/bash_completion" to load the new/updated completions (or log out and back in again).
 
Old 04-17-2011, 09:26 PM   #5
sahko
Senior Member
 
Registered: Sep 2008
Distribution: Slackware
Posts: 1,041

Rep: Reputation: Disabled
Please send your completion files upstream for inclusion in next release if you haven't already. That way everyone can benefit from them.
 
Old 04-18-2011, 12:20 PM   #6
_GArik_
LQ Newbie
 
Registered: Nov 2010
Posts: 19

Original Poster
Rep: Reputation: 6
Quote:
Originally Posted by rworkman View Post
Are the versions of the pkgtool, slapt-get, sbopkg, and slackpkg completion stubs different than the ones we put in the /usr/doc/bash-completion-1.3/contrib/ directory?
Yes small corrections were made to resolve minor issues. Log is available here.

Separate files can be taken here:
pkgtools
rpm2tgz
sbopkg
slackpkg
slap-get/slapt-src
 
Old 04-18-2011, 12:28 PM   #7
_GArik_
LQ Newbie
 
Registered: Nov 2010
Posts: 19

Original Poster
Rep: Reputation: 6
Quote:
Originally Posted by sahko View Post
Please send your completion files upstream for inclusion in next release if you haven't already. That way everyone can benefit from them.
I'll send it, when it tested.
Pat's opinion:
Quote:
Sorry, but these contrib scripts have been causing a lot of problems. If these are merged with upstream (and hopefully debugged) then we will have them, but adding them at this level is IMHO a mistake.
I don't actually see any problems with these completions and I need feedback and testing from people who has some concerns about completions. So test completions if you are interested in it.
 
Old 04-18-2011, 09:30 PM   #8
rworkman
Slackware Contributor
 
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 1,913

Rep: Reputation: Disabled
Here's the thread that resulted in us moving the new completions to $docdir/contrib: http://www.linuxquestions.org/questi...ailure-863157/
 
Old 04-19-2011, 04:44 AM   #9
_GArik_
LQ Newbie
 
Registered: Nov 2010
Posts: 19

Original Poster
Rep: Reputation: 6
I think this issue was resolved with this commit:
Quote:
Replace hyphens with underscores in function names
GArik (author)
March 28, 2011
Link to commit
 
Old 04-19-2011, 09:06 AM   #10
rworkman
Slackware Contributor
 
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 1,913

Rep: Reputation: Disabled
Very nice; thanks. As far as I know, that was the only problem we had that could be linked to your changes. The other major one was completion on /bin/sh, but it was a problem in upstream bash-completion and we patched it.
 
Old 04-19-2011, 03:20 PM   #11
slakmagik
Senior Member
 
Registered: Feb 2003
Distribution: Slackware
Posts: 4,113

Rep: Reputation: Disabled
_GArik_: if you fix such things, it might be useful to post that you've fixed them in the thread that caused you to make the fix.
 
Old 04-19-2011, 06:01 PM   #12
_GArik_
LQ Newbie
 
Registered: Nov 2010
Posts: 19

Original Poster
Rep: Reputation: 6
slakmagik: sure, for the next time )

rworkman: if there is no other issues left, then i can send pull request and merge these completions upstream. Can i add your name to signed-off-by line? )
 
Old 04-19-2011, 06:12 PM   #13
rworkman
Slackware Contributor
 
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 1,913

Rep: Reputation: Disabled
I'm not aware of other issues, but even so, we can't wait for perfection...

I've not tested the slapt one at all, but feel free to add this to the others:
Signed-off-by: Robby Workman <rworkman@slackware.com>

If someone here can confirm that the slapt one at least seems to work correctly, that's good enough, and you can add me to that one too.
 
Old 04-20-2011, 02:51 AM   #14
willysr
Senior Member
 
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 2,553

Rep: Reputation: 424Reputation: 424Reputation: 424Reputation: 424Reputation: 424
It has been added to -Current now
 
Old 04-29-2011, 01:25 PM   #15
_GArik_
LQ Newbie
 
Registered: Nov 2010
Posts: 19

Original Poster
Rep: Reputation: 6
Ok, guys. I have updated completions to match recent changes in master branch. Here is updated package for testing: bash-completion-20110429-noarch-1ga.txz. If no issues reported in two days, I'll make pull-request.

! Please note that only bash >= 4.1 is supported now !

Last edited by _GArik_; 04-29-2011 at 01:29 PM.
 
  


Reply

Tags
bash, slackware


Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is Off
HTML code is Off


Similar Threads
Thread Thread Starter Forum Replies Last Post
bash completion platypuus Programming 8 05-18-2010 11:17 PM
[SOLVED] Bash hostname completion not working. bartonski Linux - Software 2 11-25-2009 03:35 PM
xterm and bash completion athanatos Slackware 12 07-22-2006 12:47 PM
question about bash completion Guest1234 Linux - Software 4 02-25-2006 04:09 PM
auto-completion in bash with wildcards juanbobo Linux - Software 2 04-07-2005 12:56 AM


All times are GMT -5. The time now is 01:39 PM.

Main Menu
My LQ
Write for LQ
LinuxQuestions.org is looking for people interested in writing Editorials, Articles, Reviews, and more. If you'd like to contribute content, let us know.
Main Menu
Syndicate
RSS1  Latest Threads
RSS1  LQ News
Twitter: @linuxquestions
identi.ca: @linuxquestions
Facebook: linuxquestions Google+: linuxquestions
Open Source Consulting | Domain Registration