Slackware This Forum is for the discussion of Slackware Linux.
|
| Notices |
Welcome to LinuxQuestions.org, a friendly and active Linux Community.
You are currently viewing LQ as a guest. By joining our community you will have the ability to post topics, receive our newsletter, use the advanced search, subscribe to threads and access many other special features. Registration is quick, simple and absolutely free. Join our community today!
Note that registered members see fewer ads, and ContentLink is completely disabled once you log in.
Are you new to LinuxQuestions.org? Visit the following links:
Site Howto |
Site FAQ |
Sitemap |
Register Now
If you have any problems with the registration process or your account login, please contact us. If you need to reset your password, click here.
Having a problem logging in? Please visit this page to clear all LQ-related cookies.
 |
GNU/Linux Basic Guide
This 255-page guide will provide you with the keys to understand the philosophy of free software, teach you how to use and handle it, and give you the tools required to move easily in the world of GNU/Linux. Many users and administrators will be taking their first steps with this GNU/Linux Basic guide and it will show you how to approach and solve the problems you encounter.
Click Here to receive this Complete Guide absolutely free. |
|
 |
|
04-17-2011, 10:22 AM
|
#1
|
|
LQ Newbie
Registered: Nov 2010
Posts: 19
Rep:
|
bash-completion package needs testing
Hi, all. There are bash completion scripts for various slackware related tools -- pkgtools, rpm2tgz, sbopkg, slackpkg, slapt-get / slapt-src. All this completions are more or less tested, but some bugs can still remain as I don't actually use all listed tools. Please grab package here and test it thoroughly: bash-completion-1.3-noarch-2ga.txz. Feel free to report any concerns in this thread or on github.
|
|
|
|
04-17-2011, 10:37 AM
|
#2
|
|
LQ Newbie
Registered: May 2009
Posts: 15
Rep:
|
Thanks for post it.
Note: sbopkg completion script now included to sbopkg package.
|
|
|
|
04-17-2011, 04:00 PM
|
#3
|
|
Senior Member
Registered: Feb 2003
Distribution: Slackware
Posts: 4,113
Rep: 
|
Quote:
Originally Posted by bmn
Note: sbopkg completion script now included to sbopkg package.
|
_GArik_'s is, IIUC, a full bash-completion setup which has been forked from the alioth completion project to provide the additional Slackware completions. What's provided in sbopkg (or, rather, will be some sunny day in the far future when Slackware/SBo open their new stable branches and a new sbopkg can be released to go with them) was split off from _GArik_'s by Sergey V. so that it's a stand-alone completion file. (IOW, you don't need to install anything not included in a stock Slackware for all files in sbopkg to work.) Which you use is entirely up to you (depending on whether you want to add the full completion package or use something more app-specfic), but they're different.
|
|
|
|
04-17-2011, 06:25 PM
|
#4
|
|
Slackware Contributor
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 1,895
Rep: 
|
Are the versions of the pkgtool, slapt-get, sbopkg, and slackpkg completion stubs different than the ones we put in the /usr/doc/bash-completion-1.3/contrib/ directory?
Regardless of the answer to that, I think I better idea is to provide *only* the changed completion files, and instruct potential testers to place them in /etc/bash_completion.d/, and then do ". /etc/bash_completion" to load the new/updated completions (or log out and back in again).
|
|
|
|
04-17-2011, 09:26 PM
|
#5
|
|
Senior Member
Registered: Sep 2008
Distribution: Slackware
Posts: 1,041
Rep: 
|
Please send your completion files upstream for inclusion in next release if you haven't already. That way everyone can benefit from them.
|
|
|
|
04-18-2011, 12:20 PM
|
#6
|
|
LQ Newbie
Registered: Nov 2010
Posts: 19
Original Poster
Rep:
|
Quote:
Originally Posted by rworkman
Are the versions of the pkgtool, slapt-get, sbopkg, and slackpkg completion stubs different than the ones we put in the /usr/doc/bash-completion-1.3/contrib/ directory?
|
Yes small corrections were made to resolve minor issues. Log is available here.
Separate files can be taken here:
pkgtools
rpm2tgz
sbopkg
slackpkg
slap-get/slapt-src
|
|
|
|
04-18-2011, 12:28 PM
|
#7
|
|
LQ Newbie
Registered: Nov 2010
Posts: 19
Original Poster
Rep:
|
Quote:
Originally Posted by sahko
Please send your completion files upstream for inclusion in next release if you haven't already. That way everyone can benefit from them.
|
I'll send it, when it tested.
Pat's opinion:
Quote:
|
Sorry, but these contrib scripts have been causing a lot of problems. If these are merged with upstream (and hopefully debugged) then we will have them, but adding them at this level is IMHO a mistake.
|
I don't actually see any problems with these completions and I need feedback and testing from people who has some concerns about completions. So test completions if you are interested in it.
|
|
|
|
04-18-2011, 09:30 PM
|
#8
|
|
Slackware Contributor
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 1,895
Rep: 
|
Here's the thread that resulted in us moving the new completions to $docdir/contrib: http://www.linuxquestions.org/questi...ailure-863157/
|
|
|
|
04-19-2011, 04:44 AM
|
#9
|
|
LQ Newbie
Registered: Nov 2010
Posts: 19
Original Poster
Rep:
|
I think this issue was resolved with this commit:
Quote:
Replace hyphens with underscores in function names
GArik (author)
March 28, 2011
|
Link to commit
|
|
|
|
04-19-2011, 09:06 AM
|
#10
|
|
Slackware Contributor
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 1,895
Rep: 
|
Very nice; thanks. As far as I know, that was the only problem we had that could be linked to your changes. The other major one was completion on /bin/sh, but it was a problem in upstream bash-completion and we patched it.
|
|
|
|
04-19-2011, 03:20 PM
|
#11
|
|
Senior Member
Registered: Feb 2003
Distribution: Slackware
Posts: 4,113
Rep: 
|
_GArik_: if you fix such things, it might be useful to post that you've fixed them in the thread that caused you to make the fix. 
|
|
|
|
04-19-2011, 06:01 PM
|
#12
|
|
LQ Newbie
Registered: Nov 2010
Posts: 19
Original Poster
Rep:
|
slakmagik: sure, for the next time )
rworkman: if there is no other issues left, then i can send pull request and merge these completions upstream. Can i add your name to signed-off-by line? )
|
|
|
|
04-19-2011, 06:12 PM
|
#13
|
|
Slackware Contributor
Registered: Oct 2004
Location: Tuscaloosa, Alabama (USA)
Distribution: Slackware
Posts: 1,895
Rep: 
|
I'm not aware of other issues, but even so, we can't wait for perfection...
I've not tested the slapt one at all, but feel free to add this to the others:
Signed-off-by: Robby Workman <rworkman@slackware.com>
If someone here can confirm that the slapt one at least seems to work correctly, that's good enough, and you can add me to that one too.
|
|
|
|
04-20-2011, 02:51 AM
|
#14
|
|
Senior Member
Registered: Jul 2004
Location: Jogja, Indonesia
Distribution: Slackware-Current
Posts: 1,905
|
It has been added to -Current now 
|
|
|
|
04-29-2011, 01:25 PM
|
#15
|
|
LQ Newbie
Registered: Nov 2010
Posts: 19
Original Poster
Rep:
|
Ok, guys. I have updated completions to match recent changes in master branch. Here is updated package for testing: bash-completion-20110429-noarch-1ga.txz. If no issues reported in two days, I'll make pull-request.
! Please note that only bash >= 4.1 is supported now !
Last edited by _GArik_; 04-29-2011 at 01:29 PM.
|
|
|
|
| Thread Tools |
Search this Thread |
|
|
|
Posting Rules
|
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts
HTML code is Off
|
|
|
All times are GMT -5. The time now is 11:09 PM.
|
|
LinuxQuestions.org is looking for people interested in writing
Editorials, Articles, Reviews, and more. If you'd like to contribute
content, let us know.
|
Latest Threads
LQ News
|
|