LinuxQuestions.org

LinuxQuestions.org (/questions/)
-   Slackware (http://www.linuxquestions.org/questions/slackware-14/)
-   -   bash-completion package needs testing (http://www.linuxquestions.org/questions/slackware-14/bash-completion-package-needs-testing-875458/)

_GArik_ 04-17-2011 10:22 AM

bash-completion package needs testing
 
Hi, all. There are bash completion scripts for various slackware related tools -- pkgtools, rpm2tgz, sbopkg, slackpkg, slapt-get / slapt-src. All this completions are more or less tested, but some bugs can still remain as I don't actually use all listed tools. Please grab package here and test it thoroughly: bash-completion-1.3-noarch-2ga.txz. Feel free to report any concerns in this thread or on github.

bmn 04-17-2011 10:37 AM

Thanks for post it.
Note: sbopkg completion script now included to sbopkg package.

slakmagik 04-17-2011 04:00 PM

Quote:

Originally Posted by bmn (Post 4327104)
Note: sbopkg completion script now included to sbopkg package.

_GArik_'s is, IIUC, a full bash-completion setup which has been forked from the alioth completion project to provide the additional Slackware completions. What's provided in sbopkg (or, rather, will be some sunny day in the far future when Slackware/SBo open their new stable branches and a new sbopkg can be released to go with them) was split off from _GArik_'s by Sergey V. so that it's a stand-alone completion file. (IOW, you don't need to install anything not included in a stock Slackware for all files in sbopkg to work.) Which you use is entirely up to you (depending on whether you want to add the full completion package or use something more app-specfic), but they're different.

rworkman 04-17-2011 06:25 PM

Are the versions of the pkgtool, slapt-get, sbopkg, and slackpkg completion stubs different than the ones we put in the /usr/doc/bash-completion-1.3/contrib/ directory?

Regardless of the answer to that, I think I better idea is to provide *only* the changed completion files, and instruct potential testers to place them in /etc/bash_completion.d/, and then do ". /etc/bash_completion" to load the new/updated completions (or log out and back in again).

sahko 04-17-2011 09:26 PM

Please send your completion files upstream for inclusion in next release if you haven't already. That way everyone can benefit from them.

_GArik_ 04-18-2011 12:20 PM

Quote:

Originally Posted by rworkman (Post 4327428)
Are the versions of the pkgtool, slapt-get, sbopkg, and slackpkg completion stubs different than the ones we put in the /usr/doc/bash-completion-1.3/contrib/ directory?

Yes small corrections were made to resolve minor issues. Log is available here.

Separate files can be taken here:
pkgtools
rpm2tgz
sbopkg
slackpkg
slap-get/slapt-src

_GArik_ 04-18-2011 12:28 PM

Quote:

Originally Posted by sahko (Post 4327544)
Please send your completion files upstream for inclusion in next release if you haven't already. That way everyone can benefit from them.

I'll send it, when it tested.
Pat's opinion:
Quote:

Sorry, but these contrib scripts have been causing a lot of problems. If these are merged with upstream (and hopefully debugged) then we will have them, but adding them at this level is IMHO a mistake.
I don't actually see any problems with these completions and I need feedback and testing from people who has some concerns about completions. So test completions if you are interested in it.

rworkman 04-18-2011 09:30 PM

Here's the thread that resulted in us moving the new completions to $docdir/contrib: http://www.linuxquestions.org/questi...ailure-863157/

_GArik_ 04-19-2011 04:44 AM

I think this issue was resolved with this commit:
Quote:

Replace hyphens with underscores in function names
GArik (author)
March 28, 2011
Link to commit

rworkman 04-19-2011 09:06 AM

Very nice; thanks. As far as I know, that was the only problem we had that could be linked to your changes. The other major one was completion on /bin/sh, but it was a problem in upstream bash-completion and we patched it.

slakmagik 04-19-2011 03:20 PM

_GArik_: if you fix such things, it might be useful to post that you've fixed them in the thread that caused you to make the fix. :)

_GArik_ 04-19-2011 06:01 PM

slakmagik: sure, for the next time )

rworkman: if there is no other issues left, then i can send pull request and merge these completions upstream. Can i add your name to signed-off-by line? )

rworkman 04-19-2011 06:12 PM

I'm not aware of other issues, but even so, we can't wait for perfection...

I've not tested the slapt one at all, but feel free to add this to the others:
Signed-off-by: Robby Workman <rworkman@slackware.com>

If someone here can confirm that the slapt one at least seems to work correctly, that's good enough, and you can add me to that one too.

willysr 04-20-2011 02:51 AM

It has been added to -Current now :)

_GArik_ 04-29-2011 01:25 PM

Ok, guys. I have updated completions to match recent changes in master branch. Here is updated package for testing: bash-completion-20110429-noarch-1ga.txz. If no issues reported in two days, I'll make pull-request.

! Please note that only bash >= 4.1 is supported now !


All times are GMT -5. The time now is 11:03 PM.