bash-completion-1.3-noarch-1 causes xorg failure

andrewthomas · 02-16-2011, 04:21 PM

/etc/bash_completion.d/slapt has a syntax error that causes x to fail to load. I had to move the file to be able to run x.

Here is the offending file:

http://pastebin.com/C2UiRwMn

ppr:kut · 02-17-2011, 01:57 AM

I don't see any error here, works fine for me. What's the error you get?

chrisretusn · 02-17-2011, 08:01 AM

I've been looking to install bash-completion anyway so I used this as an excuse to do so. The install on both my 32-bit and 64-bit machines when perfectly. I am not experiencing any post installation problems. In fact I wonder why I have waited so long to install it, nice!

The offending file you linked to looks to be a slapt-get script. Are you using slapt-get to install bash-completion?

Since bash-completion is located in Slackware extra I would recommend using slackpkg as the best choice to install this. In fact I would recommend slackpkg be used for all packages that are part of Slackware.

# slackpkg install bash-completion-1.3-noarch-1.txz

ppr:kut · 02-17-2011, 08:17 AM

No, there is an actual slapt completion file included in the latest package, together with completion support for pkgtool, slackpkg, sbopkg and a few others.

chrisretusn · 02-17-2011, 08:43 AM

OOPS. Misread the post. It's a bash-completion script. I don't use slapt so naturally I won't see a problem.

I will admit that I have having a real problem seeing how this would effect X though.

andrewthomas · 02-17-2011, 09:40 AM

Here is the error from .xsession-errors

Code:

/etc/X11/gdm/Xsession: Beginning session setup...
/etc/bash_completion.d/slapt: line 69: `_slapt-get': not a valid identifier

When booting

Code:

Starting up X11 session manager...
/etc/bash_completion.d/slapt: line 69: `_slapt-get': not a valid identifier
/etc/bash_completion.d/slapt: line 69: `_slapt-get': not a valid identifier
about 20 times then 
init: Id "x" respawning too fast: disabled for 5 minutes.

I did install the pkg with slapt-get. I will try to reinstall with slackpkg and see what happens.

ppr:kut · 02-17-2011, 09:49 AM

Since you are using gdm, you could try with kdm just to see whether it's a gdm issue or not

ponce · 02-17-2011, 11:08 AM

I'll put here just a small note related to this new version of bash-completion (with 1.2 there's no such problem): if you have also adobe-reader installed, you will experiment that when you try to complete with tab a dir name with the command ls, for example, bash will complete it without the trailing slash and will put a space instead

looking around a little I found this archlinux bug that linked this AUR page.

the file /etc/bash_completion.d/acroread got a conflicting function that you can fix with this sed

Code:

sed -i "s/_filedir/_filedir_acroread/" /etc/bash_completion.d/acroread

(you can also remove the entire _filedir function from the above file

)

after that, everything goes back to normal behaviour

andrewthomas · 02-17-2011, 11:28 AM

Quote:

Originally Posted by ppr:kut

Since you are using gdm, you could try with kdm just to see whether it's a gdm issue or not

When I changed the runlevel to 3 in inittab and used startx there was no problem. So you are correct that it is a gdm issue.

rworkman · 02-25-2011, 12:20 AM

What shell are you using?
What is root's shell?
If you change "#!/bin/sh" in /etc/X11/gdm/Xsession to "#!/bin/bash", does that make the error go away?

andrewthomas · 02-26-2011, 05:37 PM

Quote:

Originally Posted by rworkman

What shell are you using?
What is root's shell?
If you change "#!/bin/sh" in /etc/X11/gdm/Xsession to "#!/bin/bash", does that make the error go away?

Nope.

Code:

/bin/sh -> bash*

rworkman · 02-26-2011, 07:10 PM

Well, there goes that idea. I don't know what's happening there. I'm using gdm on multiple boxes with this stuff installed, and there are no problems here... :/

slakmagik · 04-19-2011, 01:09 AM

(Edit: turns out the below was right but has been fixed upstream.)

Following the link from the completion thread:

Apologies if I'm not following properly, but _slapt-get isn't a valid identifier because of the '-'. For some reason, bash-as-bash ignores it but bash-as-sh is stricter about identifiers being _alphanumeric only.

Code:

:_not-valid() { echo foo; }
sh: `_not-valid': not a valid identifier

:_not_valid() { echo foo; }

andrewthomas: just because sh is a link to bash doesn't mean you couldn't try changing the shebang line. Bash behaves differently depending on how it's called. How it's working for anyone, I don't know, but it shouldn't. (I don't use any *dm or the completion package, so I dunno.) But just using valid identifiers should fix it.