Script only works from konsole

Fixit7 · 05-05-2014, 05:26 PM

For some reason, this only works from a konsole using FatDog.

It does not work when run from a File Manager.

Same script works fine with Puppy 5.6. using Thunar, etc.

Code:

# Linux Puppy 6.5.0 and FatDog
#  Cpu_Temp.sh  Show CPU temperatures (duo core in my case)
# "echo" creates a newline in a text file
#
# 1st check if sensors is installed
cd /
cd root/my-applications/lm_sensors-3.3.5/prog/sensors
date "+DATE: %m/%d/%y%nTIME: %r" >> cpu_temp.txt
echo >> cpu_temp.txt
sensors -f >> cpu_temp.txt
geany cpu_temp.txt

_________________
Andy

Slacko Puppy 5.6.0
Windows XP SP3

jailbait · 05-05-2014, 07:39 PM

This may be a problem with different PATHs being available in the various places you start the script. Try giving the full file name when you invoke the sensors and geany commands.

---------------------
Steve Stites

Fixit7 · 05-06-2014, 03:55 PM

I think the problem is with Xfe file manager.

None of the scripts work when double clicked.

Andy

I prefer Thunar but can not get it installed.

unSpawn · 05-06-2014, 04:07 PM

...also I would rewrite the script as a proper shell script:

Code:

#!/bin/bash --
# Uncomment for debug output when testing:
# set -vxe
# Set default behaviour:
LANG=C; LC_ALL=C; export LANG LC_ALL

# Check if lm_sensors is installed:
which sensors >/dev/null 2>&1 || { echo "lm_sensors not installed, exiting."; exit 127; }

# Check if logger is installed (see 'man logger'):
which logger >/dev/null 2>&1 || { echo "logger not installed, exiting."; exit 127; }

# Sensors should be properly installed, not in /root/my-applications/lm_sensors-3.3.5/prog/sensors!
# Loop over the lines of output and have logger inset it into syslog. This way you keep your data central,
# (for which you actually should use the SysV init script and service lm_sensor sprovides IMHO) and you get
# time stamps for free.
sensors -f | while read LINE; do logger -t sensors "${LINE}"; done

exit 0

Now you can save this script as say "/etc/cron.hourly/sensors.cron" and if you want to check the values open a terminal window and run say

Code:

tail -f /var/log/messages|grep sensors

Fixit7 · 05-06-2014, 05:18 PM

I saved your script as .sh but it does the same as my script.

I think it is a File Manager issue.

Andy

unSpawn · 05-06-2014, 06:10 PM

Quote:

Originally Posted by Fixit7

I saved your script as .sh but it does the same as my script.

Note my script won't give you output the way your script does nor does it open geany for you. Also note you seem to have installed sensors in /root/my-applications/lm_sensors-3.3.5/prog/ instead of /usr/bin or /usr/local/bin. That is not how you should install applications and "/root/my-applications/lm_sensors-3.3.5/prog/" most definitely will not be in your

Code:

echo $PATH

Fixit7 · 05-06-2014, 06:14 PM

Thanks.

I could not install sensors using the package manager.

It could not find sensors, so I did my own manual install.

I just installed midnight commander and my scripts work fine.

I prefer Thunar, but can live with mc.

FatDog does not create menu entries for any newly installed programs which is a big no-no in my book. :-)

Andy

I mainly use Puppy Slacko 5.6 for most of my work.