what's wrong

ej25 · 11-22-2004, 01:21 AM

what's wrong with this code:
c=4;
for(j=0;j!=c;j++){
printf("section number %d\n",j);
while(ii!=10){
fscanf(fd,"%d",&a);
printf("a:%d\n",a);
Sum1=Sum1+a;
i=1;
while(i!=c){
fscanf(fd,"%d",&a);
i++;
}
ii++;
}
printf("%d\n",Sum1);
aver1 = Sum1 / (float) ii;
printf("%f\n",aver1);

}

the wrong output looks like this :
section number 0
a:1
a:4
a:9
a:19
a:8
a:10
a:10
a:9
a:15
a:10
95
9.500000
section number 1
95
9.500000
section number 2
95
9.500000
section number 3
95
9.500000

itsme86 · 11-22-2004, 01:57 AM

Umm...it's not in code tags?

You never actually declare any of the variables you're trying to use?

What output were you actually expecting?

jlliagre · 11-22-2004, 02:10 AM

Quote:

what's wrong with this code:

It's not indented ...

ej25 · 11-22-2004, 05:04 AM

This is part of my code, I declared every thing.

the output should look similar to this:

section number 0
a:1
a:4
a:9
a:19
a:8
a:10
a:10
a:9
a:15
a:10
95
9.500000
section number 1
a:1
a:4
a:9
a:19
a:8
a:10
a:10
a:9
a:15
a:10
95
9.500000
section number 2
a:1
a:4
a:9
a:19
a:8
a:10
a:10
a:9
a:15
a:10
95
9.500000
section number 3
a:1
a:4
a:9
a:19
a:8
a:10
a:10
a:9
a:15
a:10
95
9.500000

but with different number in each section

this code only execute this part after the correct execution of section 1

printf("%d\n",Sum1);
aver1 = Sum1 / (float) ii;
printf("%f\n",aver1);

jlliagre · 11-22-2004, 05:47 AM

Can you tell what is your code supposed to do (not to output) ?

ej25 · 11-22-2004, 11:54 AM

my code read from a file which has four column and 10 rows then it print the sum and average of each column

jlliagre · 11-22-2004, 12:20 PM

Okay, can you post your full real code, as the first one posted has typos and won't compile.

itsme86 · 11-22-2004, 12:23 PM

And don't forget to use code tags!

ej25 · 11-23-2004, 04:09 AM

this the code:

Code:

 
#include <stdio.h> 
#include <stdlib.h>
#include <fcntl.h>             /* defines options flags */ 
#include <sys/types.h>     /* defines types used by sys/stat.h */ 
#include <sys/stat.h>        /* defines S_IREAD & S_IWRITE  */ 

int main( )
{

FILE *fd;
int fd2;
int sec,quize;
char buffer[1024];
char buffer2[1024];
int a,b,n,c;
int random[c][10];
int i,Sum1,Sum2,ii;
float aver1,aver2;
int j;
fd = fopen("input.txt","w+");
   
printf("Enter number of sections:");
scanf("%d",&sec);

printf("Enter number of quizes in each section:");
scanf("%d",&quize);
 c= sec*quize;


for(a=0;a<c;a++){
 for(b=0;b<10;b++)
 random[a][b]=rand()%21;}
 
for(b=0;b<10;b++){
for(a=0;a<c;a++){
 fprintf(fd,"%d",random[a][b]);
 fprintf(fd,"\t");}
 fprintf(fd,"\n");}

  
  fclose (fd);  
        
fd = fopen("input.txt","r+");
i=1;
ii=0;
Sum1=0;
Sum2=0;
j=0;
for(j=0;j!=c;j++){
printf("section number %d\n",j);
while(ii!=10){
fscanf(fd,"%d",&a);
printf("a:%d\n",a);
Sum1=Sum1+a;
i=1;
while(i!=c){
fscanf(fd,"%d",&a);
i++;
}
ii++;
}
printf("%d\n",Sum1);
aver1 = Sum1 / (float) ii;

printf("%f\n",aver1);

}
close(fd);   
        return (0);

         
    }

jlliagre · 11-23-2004, 08:26 AM

This is definitively wrong:

Code:

int random[c][10];

ej25 · 11-23-2004, 11:37 AM

whay???????

itsme86 · 11-23-2004, 11:45 AM

You haven't initialized c to anything. You can't tell the array to be of size c when c is some uninitialized, random value.

ej25 · 11-23-2004, 12:05 PM

if I initialized c to 0 it give me "Segmentation fault"
and if I initialized to any number the same problem still

itsme86 · 11-23-2004, 12:10 PM

You're going to need to do this with memory allocation to do it right. Otherwise you're going to need to put an upper limit on how many sections and how many quizzes they can enter.

ej25 · 11-24-2004, 01:20 AM

I didn't get it !!!!!!!!!

how can I allocate memory if I don't know the value of c
when I declared an array I'm reserving a memory location, isn't it?
can you give me an example?