to become giddy in simple code

Hamid Moradmand · 05-18-2004, 03:07 AM

Hi there!
When I enter a certain number, I don't recieve suitable answer.
what's wrong in my code source?

Thanks for your help

Code source
-------------------------------------------------
#include <stdio.h>
int main()
{
int num;
printf("\nEnter a number between 1 to 10:");
scanf("%d",num);
#if num == 1
printf("\nyou insert %d",num);
#elif num == 2
printf("\nyou entered %d",num);
#else
printf("\nyou entered except 1&2\n");
#endif
return 0;
}

Output
--------------------------------------------------
[root@Shvback c]# ./test2

Enter a number betwen 1 to 10:1

you entered except 1&2
Segmentation fault

itsme86 · 05-18-2004, 03:18 AM

Well, first of all, you're using preprocessor calls where you shouldn't. Second of all, you need to pass a pointer to num to scanf(). The code should look like this:

Code:

#include <stdio.h>

int main()
{
  int num;

  printf("\nEnter a number between 1 to 10:");
  scanf("%d",&num);
  if(num == 1)
    printf("\nyou insert %d",num);
  else if(num == 2)
    printf("\nyou entered %d",num);
  else
    printf("\nyou entered except 1&2\n");

  return 0;
}

note: for future reference, please post code inside [ code] and [ /code] tags for readability's sake.

AMMullan · 05-18-2004, 06:23 PM

Or you could just use:

Code:

#include <stdio.h>

int main(int argc, char *argv[]) {

  int input;

  printf("Entrer a number between 1 and 10: ");
  scanf("%d", &input);

  printf("You entered: %d :-)\n", input);

return 0;
}

Just makes it easier than using loops unnecessarily :-)