Text adventure command problem

MylesCLin · 02-10-2005, 11:54 AM

Me again.
Anyway, from my last few posts in this forum, you can tell that I'm writing some kind of txt edventure (Note the e, that's the name of my 'engine'

)
So, I've implemented basic commands, north, south, look, quit, etc.
But! I have not gotten 'get' down.
I have a basic object structure, shown here;

Code:

typedef struct item{ //item structure
int location,pickedup;
char name[20],desc[20];
void (*callback)();
} item;

and a *basic* way to 'pick up' one of those.

Code:

	if(strspn(commands,"get") == 3){
		char exbuf[10];
		int i,gotobj=0;
		printf("What item would you like to get?");
		scanf("%s",exbuf);
		printf("%s\n\n",exbuf);
		for(i = 0; i < MAXITEMS; i++){
			if(items[i].name == exbuf && items[i].location == curoom){
		    curitemnum++;
			inv[curitemnum] = i;
			printf("%s\n\n",items[i].name);
		    items[i].callback();
			gotobj = 1;
			}
		}
		if(gotobj != 1){
		printf("I cannot get that!");
		}
	}

Though when I type 'get' then 'gun' or 'Gun' it says 'I cannot get that!' as I have coded it.

Can someone help me?

Also, does anyone know how to make it accept 'get <objectname>'?

Thanks in advance.

itsme86 · 02-10-2005, 11:58 AM

Code:

if(items[i].name == exbuf...

That will never be true. Try using strcmp() instead. Using == tests for pointer equality instead of content equality.

MylesCLin · 02-10-2005, 03:23 PM

Thanks, that fixed it.
Now I have another problem.
I have it loop through the array of items and see if they are in the room, but when I have an item named gun2, it 'get's that too.
Any ideas?

MylesCLin · 02-10-2005, 06:31 PM

Anyone?

webtoe · 02-10-2005, 07:40 PM

Erm, what the code look like now? is it like this:

Code:

if(strcmp(items[i].name, exbuf) && strcmp(items[i].location, curoom)){

I'm not much of a C programmer (well, not much of a programmer at all) but would like to have a swing at it. Could it have something to do with the fact that strcmp() returns -1, 0 or 1? Depending on the comparison.

Alex

MylesCLin · 02-11-2005, 12:05 AM

That's almost what I have it do now.
No need to strcmp the location, as it is an integer, and I've removed exbuf all together.
Basically, you can type in 'get <object>' but if any other object's name starts with, for instance, 'gun', it'll pick it up too.

EDIT: Also, if strcmp returns 0, it means they match.

webtoe · 02-11-2005, 04:22 AM

Hmm, thanks for teaching me a bit more about C!

Could it be something to do with the fact that strcmp() is returning -1? this would be false, so the if statement would be false ( false && true )

Just chucking that in there to see if it is the case. As far as strcmp() is concerned, gun and gun2 should return a minus one i think. It will pad the first gun to make it length 4, but the special padding at 4 will come before 2 in the alphabet causing a return of -1. I think this is how it works but then it may not and I accept I could be going down the wrong track here.

HTH

Alex