shell script to perl script

john83reuben · 02-21-2008, 11:34 PM

I have done a script, but it is based on shell script, and i want to convert it to perl. I am very new to perl.

This is my shell script

#!/bin/bash

echo -n "Enter your name : "
read username
echo -n "Enter your password : "
read password

pass=$(perl -e 'print crypt($ARGV[0], "password")' $password)
useradd -m -p $pass $username

And i want to change it to perl script

This is how i change it, but it does not work

#!/usr/bin/perl

print "Enter your name : \n";
$username = <STDIN>;
print "Enter your password : \n";
$password = <STDIN>;

#I think my mistake is somewhere here.
$pass=$(perl -e 'print crypt($ARGV[0], "password")' $password)
system("useradd -m -p $pass $username");

PLease help me.

john83reuben · 02-22-2008, 12:23 AM

I have found the solution.Thanks

#!/usr/bin/perl

print "Enter your name : \n";
$username = <STDIN>;
print "Enter your password : \n";
chomp(my $password = <STDIN>);

$pass = crypt($password,"password");

system("useradd -m -p $pass $username");

chrism01 · 02-22-2008, 01:02 AM

Just FYI, start the top of all your Perl progs with the following 2 lines, they'll save you a lot of grief:

#!/usr/bin/perl -w
use strict;

If you haven't already, bookmark this:
http://perldoc.perl.org/

Disillusionist · 02-22-2008, 02:57 AM

If requesting a password from the command line, so that it doesn't appear when you type it, use stty -echo before the request and stty echo after:

Code:

#!/usr/bin/perl

print "Enter your name : \n";
$username = <STDIN>;
print "Enter your password : \n";
system "stty -echo";
chomp(my $password = <STDIN>);
system "stty echo";

$pass = crypt($password,"password");

system("useradd -m -p $pass $username");

Telemachos · 02-22-2008, 07:06 AM

Don't you want to chomp the $username variable as well? I don't think that you want that newline in your "useradd" command on the last line. Run this once, and you'll see that you have a newline you don't want:

Code:

#!/usr/bin/perl
use strict;
use warnings;

print "Enter your name:\n";
my $username = <STDIN>; ## should be: chomp(my $username = <STDIN>);

print "Enter your password:\n";
system "stty -echo";
chomp(my $password = <STDIN>);
system "stty echo";

print "Your username is $username, and your pass is $password.\n";

Quigi · 02-22-2008, 12:41 PM

Quote:

Originally Posted by chrism01

Just FYI, start the top of all your Perl progs with the following 2 lines, they'll save you a lot of grief:

#!/usr/bin/perl -w
use strict;

Definitely. Perl isn't installed in the same place on all computers. To be more robust, I use the following, for the same effect as the above.

Code:

#! /usr/bin/env perl
use warnings;
use strict;

/usr/bin/env is pretty much guaranteed to be there, and it will find Perl anywhere in your PATH.

chrism01 · 02-24-2008, 06:17 PM

Yeah, but actually I was indicating the '-w' , rather than the path.

Also, in some of places there is more than one version of Perl avail, so it's usually a local rule about how you specify the path eg some admins put a symlink at /usr/bin/perl which points to whichever version they want you to use.
use warnings;
is certainly one way to to do it (TMTOWTDI)