Shell script problem

canishk · 08-26-2009, 01:05 AM

Can anyone help me to find what the problem with the script

Code:

cd $CPFs
	k=0
	for i in *
	do
		if [ -d "$i" ]
		then
			ARRs[$k]="$i"
			k=$(($k+1))
			#echo "$i"
		fi
	done

for Ds in ${ARRs[@]}
	do
		echo "$Ds"
	done

When I tried this I got the following error

Code:

ARRs[0]=1: not found

Please help me.

GrapefruiTgirl · 08-26-2009, 01:30 AM

For one thing, when assigning an array element like that, you don't need the $ inside the [$k]. Remove that and try it. Should work.

Sasha

vishesh · 08-26-2009, 01:30 AM

Quote:

Originally Posted by canishk

[code]

ARRs[$k]="$i"

Try following
${ARRs[$k]}="$i"

thnks

canishk · 08-26-2009, 01:55 AM

Quote:

Originally Posted by vishesh

Try following
${ARRs[$k]}="$i"

thnks

I tried your solution, but got something like this

Code:

${ARRs[$k]}="$i"
	k=$(($k+1))

Code:

difference.sh: 42: Bad substitution

where line 42 is the last line of code(EOF).

Quote:

For one thing, when assigning an array element like that, you don't need the $ inside the [$k]. Remove that and try it. Should work.

Sasha

Sasha,

I tried Your suggestion too, I got following output.

Code:

difference.sh: 42: ARRs[k]=1: not found
difference.sh: 42: ARRs[k]=2: not found
difference.sh: 42: ARRs[k]=3: not found

Hope need some more help, Visesh and Sasha, Thank you for your kind help.

konsolebox · 08-26-2009, 02:52 AM

Quote:

Originally Posted by canishk

Code:

difference.sh: 42: Bad substitution
difference.sh: 42: ARRs[k]=1: not found
difference.sh: 42: ARRs[k]=2: not found
difference.sh: 42: ARRs[k]=3: not found

what shell are you using? bash, ksh, zsh or just plain bourne shell?

canishk · 08-26-2009, 02:58 AM

Quote:

Originally Posted by konsolebox

what shell are you using? bash, ksh, zsh or just plain bourne shell?

its bash

Code:

GNU bash, version 3.2.48(1)-release (i486-pc-linux-gnu)
Copyright (C) 2007 Free Software Foundation, Inc.

colucix · 08-26-2009, 03:39 AM

Please, try to run the script as

Code:

bash -x yourscript.sh

this will show you a trace of the actual commands executed by the shell after shell's substitutions. This is useful for debugging. And please post the result of the above here. You know... we are really curious!

Also, what is the actual content of the directory $CPFs?

Disillusionist · 08-26-2009, 03:44 AM

I copied your code (from post #1) and it worked perfectly suggesting that there is a problem with the input that it's getting.

Can you provide the output from:

Code:

ls -lb|grep '^d'

canishk · 08-27-2009, 12:13 AM

Quote:

Originally Posted by colucix

Please, try to run the script as

Code:

bash -x yourscript.sh

this will show you a trace of the actual commands executed by the shell after shell's substitutions. This is useful for debugging. And please post the result of the above here. You know... we are really curious!

Also, what is the actual content of the directory $CPFs?

Thanks,

the error only shows when I try using sh script.sh, It will not showing when I tried with bash script.sh or with ./script.sh

Problem Solved.

catkin · 08-27-2009, 03:20 AM

Quote:

Originally Posted by vishesh

Try following
${ARRs[$k]}="$i"

thnks

I don't know what that does but it is not necessary to assign the value of $i to ARRs[k]