Shell Script: How to manipulate output files

firewallengineer · 05-25-2015, 04:04 AM

Hi all, this is my draft script, but I’ve a small problem.

Code:

fweng@box:~/$ cat script
printf "Insert the Network Group name: "
read G
printf "Your Network Group name is: %s\n" "$G"
printf "create network_object_group %s\n" "$G"
while read host
do
  printf "addelement network_objects %s '' network_objects:host%s\n" "$G" "$host"
done < host.txt > output
fweng@box:~/$

Code:

fweng@box:~/$ cat host.txt
10.5.3.8
172.16.3.210
192.168.0.150
192.168.7.4
fweng@box:~/$

Code:

fweng@box:~/$ ./script
Insert the Network Group name: TEST
Your Network Group name is: TEST
create network_object_group TEST
fweng@box:~/$

Code:

fweng@box:~/$ cat output
addelement network_objects TEST '' network_objects:host10.5.3.8
addelement network_objects TEST '' network_objects:host172.16.3.210
addelement network_objects TEST '' network_objects:host192.168.0.150
addelement network_objects TEST '' network_objects:host192.168.7.4
fweng@box:~/$

The final output is supposed to be like this. I want to have “create network_object_group TEST” in the output file as well.
Please let me know how to do this.

Code:

create network_object_group TEST
addelement network_objects TEST '' network_objects:host10.5.3.8
addelement network_objects TEST '' network_objects:host172.16.3.210
addelement network_objects TEST '' network_objects:host192.168.0.150
addelement network_objects TEST '' network_objects:host192.168.7.4

smallpond · 05-25-2015, 06:42 AM

The first line of your script doesn't specify the interpreter.

NevemTeve · 05-25-2015, 07:44 AM

Add another printf line to your cycle.

grail · 05-25-2015, 08:36 AM

Why not simply redirect your printf into the file first? I would add I see no benefit of printf here that couldn't be handled by a simple echo.

firewallengineer · 05-26-2015, 02:32 AM

Quote:

Originally Posted by NevemTeve

Add another printf line to your cycle.

Thanks for your response. This is the output is I add another printf to the cycle. But this is not the expected output as I just want “create network_object_group” to be on the the first line only.

NEW CODE

Code:

fweng@box:~/$ cat test
printf "Insert the Network Group name: "
read G
printf "Your Network Group name is: %s\n" "$G"
printf "create network_object_group %s\n" "$G"
while read host
do
        printf "create network_object_group %s\n" "$G"
        printf "addelement network_objects %s '' network_objects:host%s\n" "$G" "$host"
done < host.txt > output
fweng@box:~/$

Code:

fweng@box:~/$ ./test
Insert the Network Group name: TEST-123
Your Network Group name is: TEST-123
create network_object_group TEST-123
fweng@box:~/$

Code:

fweng@box:~/$ cat output
create network_object_group TEST-123
addelement network_objects TEST-123 '' network_objects:host10.5.3.8
create network_object_group TEST-123
addelement network_objects TEST-123 '' network_objects:host172.16.3.210
create network_object_group TEST-123
addelement network_objects TEST-123 '' network_objects:host192.168.0.150
create network_object_group TEST-123
addelement network_objects TEST-123 '' network_objects:host192.168.7.4
fweng@box:~/$

NevemTeve · 05-26-2015, 03:20 AM

Then add a single printf before the cycle...

pan64 · 05-26-2015, 03:35 AM

probably only a redirection issue:

Code:

printf "create network_object_group s\n" "$G" > output
while .... < host.txt >> output

firewallengineer · 05-26-2015, 07:13 AM

Quote:

Originally Posted by pan64

probably only a redirection issue:

Code:

printf "create network_object_group s\n" "$G" > output
while .... < host.txt >> output

Thanks, but this is not the expected output

Code:

fweng@box:~/$ cat test
printf "Insert the Network Group name: "
read G
printf "Your Network Group name is: %s\n" "$G"
printf "create network_object_group %s\n" "$G"
while read host
do
        printf "create network_object_group %s\n" "$G" > output
        printf "addelement network_objects %s '' network_objects:host%s\n" "$G" "$host"
done < host.txt >> output
fweng@box:~/$

RUN CODE

Code:

fweng@box:~/$ ./test
Insert the Network Group name: TEST
Your Network Group name is: TEST
create network_object_group TEST
fweng@box:~/$

OUTPUT

Code:

fweng@box:~/$ cat output
create network_object_group TEST
addelement network_objects TEST '' network_objects:host192.168.7.4
fweng@box:~/$

pan64 · 05-26-2015, 07:23 AM

still another redirection problem, the second printf "create network_object_group %s\n" "$G" > output not only unnecessary, but that line makes some troubles too.