Hi....

i have two scripts called:
type & selecttype.
In type i have only the name of the products ex.: product1 & product2. Now, i am going to ADD product3 which includes productA, productB, productC, productD, productE, productF. so my new type script (menu) looks as below:

1) product1
2) product2
3) product3

and my current selectype looks as below ( which is set only for product1 & product2)my question is how can include the new product3 with all other multiple selections (productA, productB, productC, productD, productE, productF) into my current selectype as below:


#!/bin/sh
echo SELECTTYPE
export -n selecttypechoice

if [ "${upgrade}" == "yes" ] ; then
selecttypechoice=${upgrade_type}
else
[ -a ./types ]
if [ $? = 0 ] ; then
#### Select Type from types file
echo --title \"$installproductchoice Server Role\" --menu \"Select Role to install\" 20 48 6 > /tmp/selecttype.dialog
for vpackages in `cat types`; do
if [ "$typesexception" = "" ] ; then
echo \"$vpackages\" Role >> /tmp/selecttype.dialog;
else
echo $typesexception | grep -i "$vpackages"
if [ $? = 0 ] ; then
echo .
else
echo \"$vpackages\" Role >> /tmp/selecttype.dialog;
fi
fi
done;

dialog --file /tmp/selecttype.dialog 2> /tmp/selecttype.choice
if [ $? = 0 ] ; then
export selecttypechoice=`cat /tmp/selecttype.choice`;
else
export -n selecttypechoice;
fi
reset
echo selecttypechoice $selecttypechoice
if [ "$selecttypechoice" = "" ] ; then
echo Aborted: User Aborted while selecting a $installproductchoice Role
echo .........Try again !!
exit ;
fi
fi
fi


**** Thank you in advance for your help!!

Hi, welcome to LQ!

And the question/problem was .... ?! :}


Cheers,
Tink

But seriously mate, you're doing this allll wrong. You obviously have some (though not a lot, no offence intended) experience, and so it'll come to you.

But yes, scrap all of this and think about what you're doing. Consider shifting away from bash.

Thanks for your feed-back. But i CANNOT shift away...!!! you see when users select option: "3)product3" in the menu, they should see another menu with all the sub categories. So type would include options: 1)product1 2)product2 3)product3 when they select No.3 they should see product A-E. for that need to modify posted script "selecttype". this script is part of working production so can not shift away from bash. i need to get it right to add the new changes. So users have the option to select the new product with all the sub product. need more info. please let me know. THANKS ALL

Hi Netrock

Whilst I don't have an issue helping to make the changes necessary to ad product3 how you wish,
I would have to agree with at least part of what jamescondron has said, namely "scrap all of this and think about what you're doing".

The reason I say this is:

1. Outdated / deprecated options used (ie [ -a ./types ])
2. Further to last example, you do the test and then do nothing with it but then test the return $? (kind of a waste)
3. Testing of uninitialised variables (bad habit) eg if [ "$typesexception" = "" ] (plus should possibly be using -n or -z here)
4. echo . -- not really sure the benefit (could be wrong on this one)

Until these and possibly others, as only had a quick look, are fixed, adding to this would just compound the problems.

Lastly, probably would have this moved to programming forum so you could get better assistance.

Thank you Grail for your feedback. as i am talking to you right now i am not in the position to do facelift on this one. i need to add & let the production rolls. "SHOW MUST GO ON". but once get my learning advance to the point where i can write Bash Script, I WILL CHANGE ALL THIS.