[SOLVED] Script is working fine but getting Command not found error

harpal singh · 01-15-2013, 02:05 AM

Hi ,

I am using below script to do some work. But even though script is working fine but while executing it i am getting command not found error.

Here is the script :-

#!/bin/sh
Names="name.txt"

###main#####
for LINE in `cat ${Names}`
do
Name=`echo $LINE |awk -F'|' '{print $1}'`
`<some Command>:$Name`
echo $Name is unlocked
done
echo "Unlocking is done"

NOte:- its reading Names one by one from file and executing some commmnad. Functionality is working fine but i am not sure whey
"./script.sh: line 11: Unlocked: command not found" is coming.

konsolebox · 01-15-2013, 03:15 AM

Try placing your variables inside double quotes e.g. "$VAR". Also if contents of name.txt has to be processed line by line, use "while read" instead:

Code:

while read LINE; do
     Name=`echo "$LINE" | awk -F'|' '{print $1}'`
     ...
done < "$Names"

If it's necessary to keep leading and trailing spaces, or if IFS is expected to be altered, use IFS='' before read:

Code:

while IFS='' read LINE; do

Note that adding extra command like that could slow down loop speed by 50% though not really significant.

NevemTeve · 01-15-2013, 04:49 AM

Please use [code] and [/code] tags