reading text from a file

mrobertson · 06-27-2005, 01:34 PM

I have the following code:

Code:

<?php

$filename = "C:\Camera Data\camdata.txt";

$myfile = fopen($filename, "r");

$fcontents = file($filename);

while(list ($line_num, $line) = each ($fcontents)) {
	echo "<p><b>Line $line_num:</b>" . str_replace("<p>", "", $line) . <br>\n;
}

fclose($myFile);

?>

When I try to run this script via apache 2 web server I get the following error:

Fatal error: Only variables can be passed by reference in C:\Program Files\Apache Group\Apache2\htdocs\PHP3Camera2.php on line 9

Does anyone see what the problem may be here. I am just trying to read each line of a text file.

Matir · 06-27-2005, 01:55 PM

Well, you do seem to be missing some quotes around the <br> tag there. Other than that, I don't see a syntax error, but perhaps some logic errors. (The while loop and the list for each).

Hko · 06-27-2005, 02:15 PM

When using file(), you don't need to fopen() it fist. Not sure if this causes the problem though.

Also, I'd prefer a loop like this instead:

Code:

foreach ($fcontents as $line_num => $line) {
    // ....
}

Matir · 06-27-2005, 02:29 PM

Excellent point, Hko. I'm not sure how I missed that one. file() does not require a previous fopen(), and would probably not be fun.

mrobertson · 06-28-2005, 07:19 AM

Thank both of you very much for your help. I finally got the script working as I would like it to. I have one last question however.....My output looks as follows:

Line 0:The coil ID is 1325462

Line 1:The coil width is 45.000

Line 2:The coil footage count is 97

Line 3:The coil length is 536

How would I just print the sentence and not line number?

Proud · 06-28-2005, 07:38 AM

Remove

Code:

"<p><b>Line $line_num:</b>" .

from the echo line?

mrobertson · 06-28-2005, 08:03 AM

Thanks alot! It works perfectly!

Matir · 06-28-2005, 08:53 AM

It now looks like you're just trying to print out a file, which could be done with this one-liner:

Code:

print str_replace("\n","<br>",file($filename));

But I could be wrong. Just a thought to keep in mind.

mrobertson · 06-28-2005, 08:55 AM

Thanks...the code that I have now works exactly how I wanted it.

Hko · 06-28-2005, 11:17 AM

Quote:

Originally posted by Matir
It now looks like you're just trying to print out a file, which could be done with this one-liner:

Code:

print str_replace("\n","<br>",file($filename));

As a side note to this:
There even is a special PHP function to do this (nl2br()):

PHP Code:



print nl2br(file($filename));

Matir · 06-28-2005, 11:21 AM

That is something I never knew, but is very cool.

mrobertson · 06-28-2005, 11:54 AM

what does that special function mean and do?

Proud · 06-28-2005, 12:00 PM

http://www.php.net/manual/en/function.nl2br.php

Matir · 06-28-2005, 12:00 PM

As the manual says, it "Inserts HTML line breaks before all newlines in a string".

Matir · 06-28-2005, 12:01 PM

LOL, nice work Proud.