reading in string with fgets

bostonbanana · 12-11-2004, 01:52 AM

Hello. I'm a newbie here and this is my first post.

I am having so much trouble with this...i am about to die!!!
I am trying to read in from a file that has:

first, second, third line contain some random string with white spaces
rest of the lines contain int or float...

this is part of the code i wrote:

Code:

while ((fgets(temp1.Name, 50, ifp) && 
          fgets(temp1.Type, 50, ifp) &&
	  fgets(temp1.Size, 50, ifp) != NULL) &&
          (fscanf (ifp, "%d%d%f%d%f%d%d%d%d",
                 &temp1.c, &temp1.s,
                 &temp1.f, &temp1.c,
                 &temp1.s, &temp.1c, 
                 &temp1.g, &temp1.f,
		   &temp1.p) != EOF))
     {
        if((x = strstr(temp1.Name, "\n"))!= NULL) *x=0;
        if((x = strstr(temp1.Type, "\n"))!= NULL) *x=0;
        if((x = strstr(temp1.Size, "\n"))!= NULL) *x=0;

   
        temp = CreateNode();
        SetData(temp, temp1);
        Insert(&headNode, temp);
     }

Please help!!!

Mara · 12-11-2004, 04:50 PM

Where is the problem exactly? I must say that I'd do this in a completely different way. I'd read it char after char, checking which line it is in. Also, using fscanf is not a very good idea if there's possibility of values not beeing fully correct.

bostonbanana · 12-11-2004, 05:49 PM

there is total of 12 items i am reading in...and those 12 items repeat...
after reading in the first 12 items, it messes up...

anyways, the code works fine it's just that i didn't not expect a new line character after 12th item(integer) would cause a problem since i am reading it in with fscanf.
so after fixing it to

[code]while ((fgets(temp1.Name, 50, ifp) &&
fgets(temp1.Type, 50, ifp) &&
fgets(temp1.Size, 50, ifp) != NULL) &&
(fscanf (ifp, "%d%d%f%d%f%d%d%d%d%c",
&temp1.c, &temp1.s,
&temp1.f, &temp1.c,
&temp1.s, &temp.1c,
&temp1.g, &temp1.f,
&temp1.p, &junk) != EOF))
[\code]

notice extra %c and i am reading it into junk.
it works fine now.
it only took me 12hrs to figure it out. T_T i am going to cry now...

thanks for responding

bostonbanana · 12-11-2004, 06:14 PM

nevermind...
it doesn't quite work.
anyways,
if((x = strstr(temp1.Name, "\n"))!= NULL) *x=0;
if((x = strstr(temp1.Type, "\n"))!= NULL) *x=0;
if((x = strstr(temp1.Size, "\n"))!= NULL) *x=0;

is this sufficient to get rid of newline character at the end of a line?
man, this is frustrating!!!!

Mara · 12-12-2004, 02:10 PM

It should work (the part with replacing '\n's).

Your problems may be related to the fact of 50 character limit and that fgets finishes after finding \n. Also using fscanf may not always be safe as it requires interpretation of the string which may be not always correct.