Reading From Text File In Bash

ke3r4 · 11-08-2010, 02:27 PM

Hello everyone.. i am kinda new in bash language , well i did some good stuff but still am a beginner so Here is what i cant figure out
I need to Read a path of a file witch is written in Text file
i used this

Code:

FILENAME=$1
while read line
do
echo $line
done < $FILENAME

it worked and showed me the Line witch was written in my file
but now my problem is how am gonna use that line as a path
i mean for example if am gonna execute a linux command on that file
like dpkg -i /path/to/the/file how am gonna export it from The $Line variable and use it after the command
i know it may be easy for most of you but as i said am only a beginner
i hope i can find help. Thank's

acvoight · 11-08-2010, 02:36 PM

You could store $line in an array. This document would be useful.

If it's only one line that is the path, just assign it to a variable called, for example, path--while read line; do path=$line; done < $FILENAME

I have a nagging feeling there is some better way to do it in the second case, but I can't think of it.

ke3r4 · 11-08-2010, 02:46 PM

so you mean if it's an only line i can just type dpkg -i $line ??

acvoight · 11-08-2010, 02:58 PM

Yes, you could put dpkg -i $line in the while..do..done loop (instead of echo $line), as long as that loop will only read paths that you want to use dpkg -i $line on. (There's that simple solution I had the nagging feeling about!)

ke3r4 · 11-08-2010, 03:05 PM

ok i did what u said then i did sudo ./file.sh file.txt but it shows me this error ./file.sh: line 17: syntax error: unexpected end of file
here is what i did with The code

FILENAME=$1
while read line
do
dpkg -i $line
done < $FILENAME

GrapefruiTgirl · 11-08-2010, 03:24 PM

My guess at this time is that either $FILENAME or one of $line contains a space or something else pesky, OR there is garbage in the file.txt file. I would edit the code like so:

Code:

FILENAME="$1"
while read line
do
dpkg -i "$line"
done < "$FILENAME"

However if this continues to not work, please post for us the whole script (obviously there are not 17 lines in this code, so you must have more code involved (or garbage in the input file), and that may well be where the problem is). Also in case this still doesn't work, show us the contents of the input file (file.txt).

ke3r4 · 11-10-2010, 01:22 PM

sorry for being a bit late
anyway i tryed everything that's been said in here but nothing realy worked
and for the hole code lol that's the first step in my code there is nothing before it

GrapefruiTgirl · 11-10-2010, 01:29 PM

Well, post us the input data file. (if it is gigantic, you may want to "attach" it rather than post it, but if you post it, please use code tags: http://www.phpbb.com/community/faq.php?mode=bbcode#f2r1 ).

And, please show us what happens when you run your code. I.e. what I mean is, open your terminal, run your code, than copy + paste for us ALL the output, from where you ran your code, right to the end. This will show us the error messages, and maybe help us figure out what's going on.

Also - where is $1 getting set? This code of yours, must be either in a script, or be a shell function, in order for $1 to have any meaning. EDIT - I see it, never mind this part.

konsolebox · 11-11-2010, 06:23 AM

I also like to give some suggestions, just in case they could also help:

(a) verify that both files (script and text) are in UNIX format and that they have no garbage white spaces

(b) run the code with this command instead:

Code:

sudo bash ./file.sh file.txt

catkin · 11-11-2010, 07:40 AM

Quote:

Originally Posted by ke3r4

ok i did what u said then i did sudo ./file.sh file.txt but it shows me this error ./file.sh: line 17: syntax error: unexpected end of file
here is what i did with The code

FILENAME=$1
while read line
do
dpkg -i $line
done < $FILENAME

There are not 17 lines in the code you posted! Please post the whole file.sh script.

ke3r4 · 11-11-2010, 01:29 PM

PHP Code:



#!/bin/bash 
# ke3r4 
# Main/Start 
FILENAME=$1 
while read line 
do 
dpkg -i $line 
done > $FILENAME

ok here is my final code now now it just stuck after typing my password

catkin · 11-11-2010, 03:17 PM

It should be done < $FILENAME but if dpkg needs to read your password from stdin it will not work. You could try dpkg -i $line < /dev/tty and if that doesn't work we'll have to read from $FILENAME on another file descriptor so ask again.

konsolebox · 11-12-2010, 01:32 AM

@ke3r4: You should have at least followed GrapefruiTgirl's suggestion in post #6 and #8.

GrapefruiTgirl · 11-12-2010, 05:14 AM

Even though we're still awaiting further input here, I thought I'd toss this into the mix as an alternative to the above code that we're currently working with:

Code:

#!/bin/bash
xargs --arg-file=file.txt -I{} dpkg -i '{}'

Note that it may not make any difference regarding the ongoing problem(s) with the current code -it's merely a suggestion of an alternate way to accomplish the same thing. It may suffer from the same problems as the current method is experiencing.

Regardless, we still want to see the input file.

ke3r4 · 11-12-2010, 07:07 AM

Ok it's starting to piss me off

here is my original code

PHP Code:



#!/bin/bash
#ke3r4
#HybridInstaller
echo "HybridInstaller by ke3r4"
echo "checking for super user"
if [ "$(id -u)" != "0" ]; then
   echo "[-] Not a superuser." 1>&2
   exit 0
FILENAME=$1
while read line
do
dpkg -i $line
done < $FILENAME

and here is what it shows me after running sudo bash file.sh Text.txt witch in text.tx i just typed a path to a .deb file

Code:

root@ke3r4:~# bash file.sh Text.txt
HybridInstaller by ke3r4
checking for super user
file.sh: line 14: syntax error: unexpected end of file

PS: To make things clear am programming an application with gambas witch helps ubuntu users to install any application easily including packages from other distro or packages with source file that need to be compiled
this application is a GUI app. now all i want to do is to design with gambas and to do what ever the user want the application call a bash script to do it.