./queue.sh: line 17: [: : integer expression expected

tashman1989 · 08-31-2016, 01:07 PM

Dears please I need support regarding my script as you can find below my script to monitor my postfix mailq but when run my scripts I got this error :./queue.sh: line 17: [: : integer expression expected
please your support

#!/bin/bash

queuelength=`/usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'`
queuecount=`echo $queuelength | grep "[0-9]"`
crit=100

if [ "$queuelength" -eq "$crit" ]; then
(echo open relay.mydomain.com 25
sleep 8
echo helo "my relay IP"
echo mail from: postmaster@mydomain.com
sleep 2
echo rcpt to: '<tashman@mydomain.com>'
sleep 2
echo data
sleep 2
echo subject: Mail Queue Alert of Hosting server
echo
echo
echo This is a mail from Hosting Server There is a problem in Mail Queue Kindly check the server there are ${queuelength} mails in the queue
sleep 5
echo .
sleep 5
echo quit ) | telnet

fi
exit 35

NevemTeve · 08-31-2016, 01:28 PM

1. Please use [code] and [/code] tags when quoting code.

2. Please quote the actual script, otherwise we couldn't tell what is in line 17

tashman1989 · 08-31-2016, 03:14 PM

Thanks dear for your reply and kindly find below my script as per your request

Code:

#!/bin/bash
# 30/08/2016 
#else
#
#if [ "$queuecount" == "" ]; then
#        echo 0;
#else
#        echo ${queuelength};
#fi
#
# 

queuelength=`/usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'`
queuecount=`echo $queuelength | grep "[0-9]"`
crit=100

if [ "$queuelength" -gt "$crit" ]; then
(echo open rely.mydomain.com 25
sleep 8
echo helo 82.212.85.199
echo mail from: postmaster@mydomain.com
sleep 2
echo rcpt to: '<ttashman@mydomain.com>'
sleep 2
echo data
sleep 2
echo subject:  Mail Queue Alert of Hosting server 
echo
echo
echo This is a  mail from Hosting Server There is a problem in Mail Queue Kindly check the server  there are ${queuelength} mails in the queue
sleep 5
echo .
sleep 5
echo quit ) | telnet

fi
exit 35

the problem in if [ "$queuelength" -gt "$crit" ]; then //line 17

keefaz · 08-31-2016, 04:41 PM

do a ' echo "$queuelength" ' to verify what it contains

tashman1989 · 09-01-2016, 01:12 AM

Hello dear I did but no result

grail · 09-01-2016, 02:56 AM

Quote:

Originally Posted by tashman1989

Hello dear I did but no result

Which is your problem. If the variable contains no data your if does not have a digit to compare to.
So you will need to code for the instance where your variable will not contain anything.

I would also suggest using (()) when performing an arithmetic test.

pan64 · 09-01-2016, 02:56 AM

Quote:

I did but no result

give us no information. You ought to tell us what's happened exactly and what was expected. Otherwise we can only guess...

Insert set -xv at the beginning of your script and you will see what's happening and what's wrong. (that will not solve anything, just print a lot of information about the execution)

tashman1989 · 09-01-2016, 03:17 AM

Dears when running echo "$queuelength" I get below

Code:

[root@hostsvr opt]# echo "$queuelength"

[root@hostsvr opt]#

tashman1989 · 09-01-2016, 03:20 AM

dear I get below when running set -xv

Code:

[root@hostsvr opt]# set -xv ./queue.sh
printf "\033]0;%s@%s:%s\007" "${USER}" "${HOSTNAME%%.*}" "${PWD/#$HOME/~}"
++ printf '\033]0;%s@%s:%s\007' root hostsvr /opt
[root@hostsvr opt]#

printf "\033]0;%s@%s:%s\007" "${USER}" "${HOSTNAME%%.*}" "${PWD/#$HOME/~}"
++ printf '\033]0;%s@%s:%s\007' root hostsvr /opt
[root@hostsvr opt]#

grail · 09-01-2016, 07:48 AM

You were supposed to place set -xv in the script after the top line

gda · 09-01-2016, 08:44 AM

As already mentioned you should check which is the output of the command:

Code:

/usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'

According to your code the output of this command is stored in the variable $queuelength that few lines after (at line 17) is compared by the if command. The if comparison at line 17 will work *ONLY* if the variable $queuelength contains an integer value. If it contains letters (or if it is empty) it will NOT work. I guess this is what happens in your case...

tashman1989 · 09-02-2016, 08:59 AM

Sorry dear grail for being late and kindly find below the out

Code:

[root@hostsvr opt]# ./queue.sh
queuelength=`/usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'`
/usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'
++ /usr/sbin/postqueue -p
++ awk '{print $5}'
++ tail -n1
+ queuelength=
queuecount=`echo $queuelength | grep "[0-9]"`
echo $queuelength | grep "[0-9]"
++ grep '[0-9]'
++ echo
+ queuecount=
crit=100
+ crit=100



if [ "$queuelength" -eq  "$crit" ]; then
(echo open relay.mydomain.com 25
sleep 8
echo helo relay.mydomain.com
echo mail from: postmaster@mydomain.com
sleep 2
echo rcpt to: '<tashman@mydomain.com>'
sleep 2
echo data
sleep 2
echo subject:  Mail Queue Alert of Hosting server
echo
echo
echo This is a  mail from Hosting Server There is a problem in Mail Queue Kindly check the server  there are ${queuelength} mails in the queue
sleep 5
echo .
sleep 5
echo quit ) | telnet

fi
+ '[' '' -eq 100 ']'
./queue.sh: line 17: [: : integer expression expected
exit 35
+ exit 35

gda · 09-02-2016, 09:19 AM

Quote:

Originally Posted by tashman1989

Code:

queuelength=`/usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'`
/usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'
++ /usr/sbin/postqueue -p
++ awk '{print $5}'
++ tail -n1
+ queuelength=
....
+ '[' '' -eq 100 ']'
./queue.sh: line 17: [: : integer expression expected
...

Here is the problem! As you can see $queuelength is not set at all. As I already told you in this case the if command will fail as it requires a numeric field.

So once again you should take of the output of the command

Code:

/usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'

Here you are looking for the fifth field (awk '{print $5}') of the last line (tail -n1) of the command /usr/sbin/postqueue -p. It seems that this quantity is not a number. Please check that executing the command reported above (or even better just the command /usr/sbin/postqueue -p) in a terminal and be sure you are catching what you really need.

tashman1989 · 09-02-2016, 09:32 AM

dear gda kindly find below /usr/sbin/postqueue -p | tail -n1 | awk '{print $5}' result

Code:

[root@hostsvr /]# /usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'

[root@hostsvr /]#

gda · 09-02-2016, 09:37 AM

Quote:

Originally Posted by tashman1989

dear gda kindly find below /usr/sbin/postqueue -p | tail -n1 | awk '{print $5}' result

Code:

[root@hostsvr /]# /usr/sbin/postqueue -p | tail -n1 | awk '{print $5}'

[root@hostsvr /]#

This means that the output of the command /usr/sbin/postqueue -p is different from what you expected.

Could you please run in a terminal:

Code:

# /usr/sbin/postqueue -p

and post the output?