[SOLVED] Problem with rm command in shell script

jdmResearch · 07-12-2011, 03:06 PM

Greetings,

I have the following script (named overscript.sh) which runs some other scripts:

Code:

#!/bin/bash 

# MUST have dcd and psf in single directory.  ONLY these two files, along with the necessary scripts, 
# should be in the directory


# Insert path of directory containing your .dcd and .psf files 
cd /home/joey/share/3TEST
# Creates the protein and water volmap files
vmd -dispdev text -e makeDxfiles.vmd
# Loop the dxTuber cmd version over the volmap files
./MOD_Loop_Tuber_Script.sh
# Remove original volmap files. Leaves the output volmaps, psf, dcd, vmd scripts, and shell scripts.
rm !(*out.dx|*.psf|*.dcd|*.vmd|*.sh)
# Loads psf, dcd, and new volmap files into VMD
vmd -e load_dx_ak.vmd

Everything works fine up until the rm command. I get the error:

Code:

./overscript.sh: line 14: syntax error near unexpected token `('
./overscript.sh: line 14: `rm !(*out.dx|*.psf|*.dcd|*.vmd|*.sh)'

When I type out the command in the terminal, it works fine. Can anyone tell me what's wrong with the script?

Thanks,
Joe

Snark1994 · 07-12-2011, 03:26 PM

This works for me:

Code:

find . -not -iname "*out.dx" -and -not -iname "*.psf" \
    -and -not -iname "*.dcd" -and -not -iname "*.vmd" -and \
    -not -iname "*.sh" -type f  -print0 | xargs rm

The problem was with the globbing you tried - "find" is more flexible

Hope this helps,

MTK358 · 07-12-2011, 05:17 PM

Have you enabled extended globbing?

Code:

shopt -s extglob

jdmResearch · 07-13-2011, 10:41 AM

Added what MTK said right before the rm command. Worked fine!

Thanks!