[SOLVED] Portable Numbers Format: PRINT Before CRASH Doesn't Work

des_a · 04-24-2014, 07:47 PM

http://forums.techguy.org/software-d...esnt-work.html

grail · 04-25-2014, 01:50 AM

ummmm .... is this a question??

des_a · 04-25-2014, 04:08 PM

Yes. This is a question.

Habitual · 04-25-2014, 04:30 PM

Doesn't have a ? mark and it appears to be a link.

Put some effort into it.

des_a · 04-25-2014, 05:17 PM

It's a link the the question.

ndc85430 · 04-26-2014, 12:56 AM

You've posted too much code. You need to start by trying to hone in on the problem area - print the values of variables at different points in the code, or use a debugger to step through the code. Once you've found the code that's causing the problem, if you're still stuck, then post just enough to reproduce the problem, along with sample input and output.

As an aside, you've got some really long methods in there (PNF::execute(), for one). This really makes the code much more difficult to follow. Prefer using shorter methods. Google for "clean code" for info about this.

grail · 04-26-2014, 04:17 AM

Surely you do not seriously expect someone else to read through 100's of lines of code to find your problem?

And whilst you may have raised a question on the other site, that is no reason to at least provide some background here and advise that you have not copied the copious amount
of code here but have provided a link for efficiency. You didn't even have the courtesy to advise what the link was to. Out of habit I do not click on links that I know nothing about.
Hence my original post.

ndc would appear to have provided some much needed pre-work for you to do before anyone here will attempt to help you.

des_a · 04-26-2014, 08:45 PM

Here are some code snippits that may have the problem in them.

The PRINT instruction:

Code:

   case IPRINT:
   {
        switch (reg.type)
        {
         case TVOID:
         {
          if (reg.operand != 0)
           crash("Invalid VOID Value.");
          else
          {
           reg.accumulator.print();
          }
         }
         break;

         case TBOOLEAN:
          switch (reg.operand)
          {
           case 0:
            cout << "false";
            break;

           case 1:
            cout << "true";
            break;

           default:
            cout << "true";
            break;
          }
          break;

         case TNUMBER:
          cout << reg.operand;
          break;

         case TCHARACTER:
          cout << (char)reg.operand;
          break;

         case TSTRING:
         {
          unsigned long is = 0;
          for (is = k; mem.get(is) != 0; ++is)          
           cout << (char)mem.get(is);

          i = is + 1;
          j = i + 1;
          k = i + 2;

          i = i - 3;
          j = i + 1;
          k = i + 2;
         }
         break;
              
         default:
          crash("Invalid Type.");
          break;
        };
   }
        break;

The CRASH instruction:

Code:

   case ICRASH:
        switch (reg.type)
        {
         case TSTRING:   
              {           
               unsigned long l;
               String str;
               for (l = k; mem.get(l) != 0; ++l)
               {
                char c = (char)mem.get(l);
                str = str + c;
               }
               i = l;
               crash(str.getString());
              }
              break;
              
         default:
                 crash("Invalid Type.");
                 break;
        }
        break;

The crash() function:

Code:

void PNF::crash(String str)
{
 error(ERROR, str);
 cout << endl;

 cout << "Registers:\n";
 cout << "==========\n";
 cout << "%icount              = " << reg.icount << endl;
 cout << endl;
 cout << "%instruction         = " << reg.instruction << endl;
 cout << "%type                = " << reg.type << endl;
 cout << "%operand             = " << reg.operand << endl;
 cout << "%typeof              = " << reg.type_of << endl;
 cout << "%accumulator         = ";
 reg.accumulator.print();
 cout << endl;
 cout << "%calc                = ";
 reg.calc.print();
 cout << endl;
 cout << "%iname               = " << reg.iname;
 cout << "\n\n";


 for (unsigned long i = 0; i < mem.length(); ++i)
  cout << "memory[" << i << "]: " << mem.get(i) << endl;
 cout << "\n\n";

 for (unsigned long i = 0; i < stk.length(); ++i)
 {
  cout << "Stack[" << i << "]: ";
  stk.top().println();
 }

 for (unsigned long i = 0; i < reg.args.length(); ++i)
  cout << "args[" << i << "]: " << reg.args.get(i) << endl;
 cout << "\n\n";
 
 
 exit(-1);
}

des_a · 04-26-2014, 09:18 PM

The error was actually in my assembler I found out. It was not assembling the code correctly because it was not giving the terminating null at the end of the string for the PRINT instruction. When I added that to assemble correctly, it worked.

grail · 04-27-2014, 02:40 AM

Good job on finding the solution and thank you for sharing it