Please explain me this

cdog · 02-20-2006, 03:26 PM

I want to see if a*b=1, that is a=1/b
a and b are float
if (a*b==1)
never seems to work (for, let's say a=1.0/2.0 and b=2.0)
Why is that?

pljvaldez · 02-20-2006, 03:46 PM

Don't know, it works for me using C programming...

My only thoughts are you forgot to include the math library or you forgot to define the variables as float or double...

Hko · 02-20-2006, 03:53 PM

Quote:

Originally Posted by cdog

I want to see if a*b=1, that is a=1/b
a and b are float
if (a*b==1)
never seems to work (for, let's say a=1.0/2.0 and b=2.0)
Why is that?

What exactly do you mean with "never seems to work". What happens? Does it compile and link without errors and warnings? Does it ouput any errors? Or does it give you wrong answers? What is the code you tried?

dmail · 02-20-2006, 04:06 PM

Quote:

Originally Posted by cdog

I want to see if a*b=1, that is a=1/b
a and b are float
if (a*b==1)
never seems to work (for, let's say a=1.0/2.0 and b=2.0)
Why is that?

this is a better way of checking for a float value.

Code:

const float epsilon = 0.00001f;

if(a*b < 1+epsilon && a*b > 1-epsilon)

<edit>a*b may not be cached( although it probably is) so an even better method maybe

Code:

float c = a*b;
if(c < 1+epsilon && c >1-epsilon)

If you want an explanation of why, then check out something like:
http://www.math.grin.edu/~stone/cour...EEE-reals.html
or one of other million web pages about the same issue.

jschiwal · 02-20-2006, 04:08 PM

With floating point numbers, your result may be 1.9999999999999 or something similar. A floating point fraction (base 10) may not be exactly convertable to a base 2 floating point number.

Instead of an equality test for floating point numbers you should check if the difference is below a small delta value.
For example, if you use a floating point variable to control a for loop and you test for equality to terminate the root, then the loop may not end.

jim mcnamara · 02-20-2006, 04:35 PM

First off -
It's standard (ie., best practice) to use these comparison macros for floats and doubles (floating point numbers):

Code:

isgreater(x,y)       
isgreaterequal(x,y)  
isless(x,y)          
islessequal(x,y)     
islessgreater(x,y)

These are in math.h - Depending on your system there are others like isunordered and so on.

The suggestion of rolling your own epsilon, while okay, still has some problems - which is why these macros came about. A very long time ago.

dmail · 02-20-2006, 05:46 PM

The use of these macros is advisable, are iso standard and maybe considered best practice but windows maths header does not include them; I normally code on windows (because theres just is not an ide which compares to visual studio in my opinion) and therefore use the above method rather than the macros. As I want my apps to work on both windows and nix.

jschiwal · 02-20-2006, 07:09 PM

Perhaps you can check if the macros are defined and if not roll your own macros.

geek_comp · 02-21-2006, 02:09 AM

dmail is almost to the point.

The storage data format for float in memory consists of integer data and its precision information. Thats why it doesnt works as it seems to be in " if(condition)" , because this loops works well only for integer values or binary values. In case of float this loop compares the precision values and gives unexpected results, sometimes it works.
better way for float comparision is to first separate the integer and data parts from the float byte.

Regards

geek

cdog · 02-21-2006, 02:32 PM

thank you guys. I figured that out alone. the problem was that it never is exactly 1 when it comes to float.
thanks again. nice responces

paulsm4 · 02-21-2006, 03:00 PM

The same question also came up in this thread:
http://www.linuxquestions.org/questi...d.php?t=416939

The_Nerd · 02-22-2006, 02:09 PM

Just do this:

Code:

#define FLOAT_EQUAL(X, Y) (X < (Y+epsilon) && X > (Y-epsilon))

then you can:

Code:

float x, y;
if (FLOAT_EQUAL(x, y)) DoSomething();

Vagrant · 02-22-2006, 03:55 PM

Quote:

Originally Posted by dmail

The use of these macros is advisable, are iso standard and maybe considered best practice but windows maths header does not include them; I normally code on windows (because theres just is not an ide which compares to visual studio in my opinion) and therefore use the above method rather than the macros. As I want my apps to work on both windows and nix.

There's vi ...