Opening a file

tarken · 02-24-2010, 11:38 AM

I am having trouble opening a file and reading its output.

This is what I have so far:

Code:

#!/bin/bash
echo "Please type a file name"
read fname
cat $fname

What am I doing wrong? When I run this nothing happens.

Tarken

irmin · 02-24-2010, 11:46 AM

The shell script is ok. If you change "cat $fname" to "echo fname=$fname", what will you see?

Your filename can contain white space, it's better to use

Code:

cat "$fname"

instead.

tarken · 02-24-2010, 11:51 AM

That worked thanks!

pixellany · 02-24-2010, 11:54 AM

Works here...

Are you sure that the file exists in the current working directory (from where you are running the script)

Also try:

Code:

#!/bin/bash
read -p "please type filename:  " fname
cat $fname

tarken · 02-24-2010, 11:54 AM

I am still having a problem with a for loop.

Code:

#!/bin/bash
echo "Please type a file name"
read fname
cat $fname           

    for i in $fname 

do
  nslookup  $i

When I run this, it tries to do a nslookup for the file I typed instead of the files output. How do I remedy this?

Tarken

tarken · 02-24-2010, 11:56 AM

Quote:

Originally Posted by pixellany

Works here...

Are you sure that the file exists in the current working directory (from where you are running the script)

Also try:

Code:

#!/bin/bash
read -p "please type filename:  " fname
cat $fname

Yeah, it was my fault. I realized that the file existed, but had no data in it. :P

pixellany · 02-24-2010, 12:06 PM

first, note the format of the "for" loop:

Code:

for <expression>; do
   <do stuff>
   <do more stuff>
done

But;
I would do it this way:

Code:

while read name; do
   <stuff>
done < filename

This reads from filename, one line at a time, and puts the line into the variable "name"

tarken · 02-24-2010, 12:14 PM

Thank you for your time!

I tried to do that, but now I am getting different errors

Here is what I have:

Code:

#!/bin/bash
echo "Please type a file name"
read fname
while read name; do

  nslookup
  ping -c 5

done

What am I doing wrong?

Tarken

irmin · 02-24-2010, 12:27 PM

Quote:

Originally Posted by tarken

Thank you for your time!

I tried to do that, but now I am getting different errors

Here is what I have:

Code:

#!/bin/bash
echo "Please type a file name"
read fname
while read name; do

  nslookup
  ping -c 5

done

What am I doing wrong?

Tarken

Do you mean:

Code:

#!/bin/bash
echo "Please type a file name"
read fname
while read name; do

  nslookup $name
  ping -c 5 $name

done < $fname

tarken · 02-24-2010, 12:44 PM

Thats what I mean! So awesome, thank you very much! One last detail. How do I get it to do all of my commands on each domain name before it moves to the next one. Currently it is doing nslookup on all of them, then pinging all of them.

Code:

#!/bin/bash
echo "Please type a file name"
read fname
while read name; do

  nslookup $name
  ping -c 5 $name
  traceroute -w 2 -m 20 $name
  if  whois $name | egrep '\w+([._-]\w)*@\w+([._-]\w)*\.\w{2,4}'; then
        null
else
echo "No email"
echo +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
fi

done < $fname

pixellany · 02-24-2010, 12:50 PM

What is the content of the variable "name" each time thru the loop? (Insert an echo command to find out.) It sounds like you are getting multiple items on one line.

irmin · 02-24-2010, 01:24 PM

Quote:

Originally Posted by tarken

Thats what I mean! So awesome, thank you very much! One last detail. How do I get it to do all of my commands on each domain name before it moves to the next one. Currently it is doing nslookup on all of them, then pinging all of them.

Code:

#!/bin/bash
echo "Please type a file name"
read fname
while read name; do

  nslookup $name
  ping -c 5 $name
  traceroute -w 2 -m 20 $name
  if  whois $name | egrep '\w+([._-]\w)*@\w+([._-]\w)*\.\w{2,4}'; then
        null
else
echo "No email"
echo +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
fi

done < $fname

You can do a while loop on the output of the commands too.

Code:

...

nslookup $domain | awk '/^Address:/ { if(ok) { print $2;} } /answer/ { ok=1; }' | while read address; do
ping -c 5 $address
done

whois $domain | egrep '\w+([._-]\w)*@\w+([._-]\w)*\.\w{2,4}' | awk '{print $2;}' | while read email; do
 echo EMAIL: $email
done

...

tarken · 02-24-2010, 03:01 PM

I keep getting a syntax error on line 16, saying an unexpected EOF. There is nothing on line 16.

Code:

#!/bin/bash
echo "Please type a file name"
read fname
while read name; do

nslookup $domain | awk '/^Address:/ { if(ok) { print $2;} } /answer/ { ok=1; }' | while read address; do
ping -c 5 $address
whois $domain | egrep '\w+([._-]\w)*@\w+([._-]\w)*\.\w{2,4}' | awk '{print $2;}' | while read email; do
 echo EMAIL: $email


done

evo2 · 02-24-2010, 03:09 PM

You have started two loops but only closed one. The script is expecting another "done".

Edit: Actually, you have started three loops. Are you unable to cut and paste from the code that people post for you?

Evo2.

irmin · 02-24-2010, 03:11 PM

note: domain = name