Node.js

Lucien Lachance · 07-17-2014, 10:15 PM

I've written a bot to retrieve all of a user's images. I noticed today that for some reason I'm receiving blank image files and I can't seem to understand why. I've provided a scenario that contains image files that it receives within the array pics. What could be causing this?

Code:

#!/usr/bin/env node

var request = require('request');
var crypto = require('crypto');
var fs = require('fs');

var md5 = function (pic) {
  var hash = crypto.createHash('md5');
  hash.update(pic);
  return hash.digest('hex');
};

var pics = ['http://37.media.tumblr.com/eea272630e7c0749241b1594b1b911b4/tumblr_n1t63oOzF81rt268so1_1280.jpg',
           'http://38.media.tumblr.com/9b40422b9129745292b174ffd683e8f3/tumblr_mvhhcuOQn41rt268so1_1280.jpg',    
           'http://37.media.tumblr.com/7f96f676610efa9beb2f322c4f6eeb36/tumblr_mudrsmtKtl1r4lu5ao1_1280.jpg'
];

for (var i = 0; i < pics.length; i++) {
  var hexDigest = md5(pics[i]) + pics[i].slice(-4);
  request(pics[i]).pipe(fs.createWriteStream(process.cwd() + '/' + hexDigest));
}

anomie · 01-12-2015, 11:22 PM

I recommend making better use of error/status reporting provided by 'request' (https://github.com/request/request). Try something like:

Code:

var fs = require('fs'),
    request = require('request'),
    uri = 'http://cartoonsimages.com/sites/default/files/field/image/' +
    'hello-kitty-para-el-facebook-15781.jpg',
    outFile = 'kitty.jpg';

request
  .get(uri)
  .on('response', function(res) {
    console.log('Response: HTTP ' + res.statusCode);
  })
  .on('error', function(err) {
    console.log('Error: ' + err);
  })
  .pipe(fs.createWriteStream(outFile));

You should be receiving HTTP 200 response codes, and no errors logged to the console. If that's not the case, needs investigation..