JavaScript

Kamikazee · 10-29-2007, 03:00 PM

Hey, I've got some code to hide/show a comment box. However for some reason it will not work using 'document.getElementsById()'...

The JavaScript

Code:

	function display(id){
		var span = document.getElementsById(id);
		for (i = 0; i < span.length; i++) {
			if (span[i].style.display=='none'){
				span[i].style.display='inline';
			} else {
				span[i].style.display='none';
			}
		}
	}

The html on the page - I'm using a templating engine so hence ID will be different for every comment box on the page.

Code:

	<p class="comment"><a href="#" onClick="JavaScript:display({docs.U_DOCID})">Make a comment</a> | 
	<a href="document.php?mode=view&d={docs.U_DOCID}">{docs.U_COMMENTS}</a></p>

		<span style="display:none" id="{docs.U_DOCID}">
		<!-- A FORM -->
		</span>

The onCLick works if i change the JavaScript to byElementsByTag("span") but that affects all the spans, not just the one.

Any help?

rednuht · 10-29-2007, 04:00 PM

have you got the pure html it produces, I would like to see the exact {docs.U_DOCID}
Interestingly the example

Code:

onClick="javascript:display({docs.U_DOCID})"

does not make use of single quotes to encase the {docs.U_DOCID} (result of)

Kamikazee · 10-29-2007, 04:23 PM

Here is the html that is produced.

Code:

<p class="comment"><a href="#" onClick="JavaScript:display(16)">Make a comment</a> | 
<a href="document.php?mode=view&d=16">0 comments</a></p>

<span style="display:none" id="16">
<!-- table -->
</span>

I also tried enclosing {docs.U_DOCID} with single quotes to produce the code below but it had no effect.

Code:

<p class="comment"><a href="#" onClick="JavaScript:display('16')">Make a comment</a>

I output'd 'id' from the js and it gives me the correct id. Which makes me assume its the script.

Code:

function display(id){
	var span = document.getElementsById(id);
	for (i = 0; i < span.length; i++) {
		if (span[i].style.display=='none'){
			span[i].style.display='inline';
		} else {
			span[i].style.display='none';
		}
	}
}