if else to run a shell script

pavan7 · 01-10-2013, 02:47 PM

Hi,

I am newbie to the forum and to scripting as well. Please help me out on this. I have written a script which checks to see if the server is down if it is down it has to exit the program, if not it should execute the scripts. Below is the sript and error I am seeing. where xyz.sh is the script I run, abc.sh and efg.sh should be excuted from with the xyz.sh script.Please help me with this. Thanks in advance:

#--------------------------------------------------------------
# checking if the server has started
#--------------------------------------------------------------

print "checking to see if server " + serverName + " is running on node " + nodeName
runningServer = AdminControl.completeObjectName("type=Server,node=" + nodeName + ",process=" + serverName + ",*")
# Following if block execute when server is down
# else block executes when server is up and running.
if (len(runningServer) == 0):
print "Error -- Server " + serverName + " not running on node " + nodeName
# return
else
'bash -c /home/abc.sh'
'bash -c /home/efg.sh'
return

Error:

Exception received while running file "/home/xyz.py"; exception information: com.ibm.bsf.BSFException: exception from Jython:
Traceback (innermost last):
(no code object) at line 0
File "<string>", line 52
else
^
SyntaxError: invalid syntax

Snark1994 · 01-10-2013, 03:20 PM

Use [CODE][/CODE] tags to wrap your code.

In bash, you don't say

Code:

if (len(runningServer) == 0):

(that looks very like python) you say

Code:

if [ ${#runningServer} -eq 0 ]; then

and you need to close the block with a "fi".

Regards,

pavan7 · 01-10-2013, 03:30 PM

you are right Sorry actually its a python calling shell

so according to python this should be right aint it?

if (len(runningServer) == 0):
print "Error -- Server " + serverName + " not running on node " + nodeName
# return

So should I change this to

if (len(runningServer) == 0):
print "Error -- Server " + serverName + " not running on node " + nodeName
# return
fi
else
'bash -c /home/abc.sh'
'bash -c /home/efg.sh'
return

Still get
exception from Jython:
Traceback (innermost last):
(no code object) at line 0
File "<string>", line 53
fi
^
SyntaxError: inconsistent dedent

Sorry for my scripting skills

Snark1994 · 01-10-2013, 03:35 PM

Like I said, use [CODE][/CODE] tags around your code in your post, so we can see the formatting better. For any language other than python, this is rather useful. As whitespace is a crucial part of python syntax, we cannot help you unless you put [CODE][/CODE] tags around your code. For example:

[CODE]your code in here[/CODE] produces

Code:

your code in here

If you're writing in python, then you need:

Code:

if (len(runningServer) == 0):
    print "Error -- Server " + serverName + " not running on node " + nodeName
else:
    'bash -c /home/abc.sh'
    'bash -c /home/efg.sh'
return

or something similar - I'm not sure exactly what logic you need to code to follow.

pavan7 · 01-10-2013, 03:42 PM

Quote:

Originally Posted by Snark1994

Like I said, use [CODE][/CODE] tags around your code in your post, so we can see the formatting better. For any language other than python, this is rather useful. As whitespace is a crucial part of python syntax, we cannot help you unless you put [CODE][/CODE] tags around your code. For example:

[CODE]your code in here[/CODE] produces

Code:

your code in here

If you're writing in python, then you need:

Code:

if (len(runningServer) == 0):
    print "Error -- Server " + serverName + " not running on node " + nodeName
else:
    'bash -c /home/abc.sh'
    'bash -c /home/efg.sh'
return

or something similar - I'm not sure exactly what logic you need to code to follow.

here it is:

Code:

   #--------------------------------------------------------------
   # checking if the server has started
   #--------------------------------------------------------------

   print "checking to see if server " + serverName + " is  running on node " + nodeName
   runningServer = AdminControl.completeObjectName("type=Server,node=" + nodeName + ",process=" + serverName + ",*")
   # Following if block execute to check if the server is down
   # else block executes when server is up and running.
   if (len(runningServer) == 0):
      print "Error -- Server " + serverName + " not running on node " + nodeName
else:
         'bash -c  /home/abc.sh'
          'bash -c  /home/efg.sh'
      return

Snark1994 · 01-10-2013, 04:22 PM

Right, in Python you need to line your code up correctly:

Code:

   if (len(runningServer) == 0):
      print "Error -- Server " + serverName + " not running on node " + nodeName
   else:            #this 'else' needs to line up with the 'if' line 
                    #(i.e. the same number of spaces at the start of both)
         'bash -c  /home/abc.sh'
         'bash -c  /home/efg.sh' #this line needs to line up with the line before
   return

Ideally, you would also make the 'print' and 'bash' lines line up, but if you don't it won't stop your code from running.

pavan7 · 01-14-2013, 02:32 PM

Thanks for responding the script seems not to throw any error but somehow its skipping this part of the code... I am working on it

Quote:

Originally Posted by Snark1994

Right, in Python you need to line your code up correctly:

Code:

   if (len(runningServer) == 0):
      print "Error -- Server " + serverName + " not running on node " + nodeName
   else:            #this 'else' needs to line up with the 'if' line 
                    #(i.e. the same number of spaces at the start of both)
         'bash -c  /home/abc.sh'
         'bash -c  /home/efg.sh' #this line needs to line up with the line before
   return

Ideally, you would also make the 'print' and 'bash' lines line up, but if you don't it won't stop your code from running.

ntubski · 01-14-2013, 10:05 PM

Quote:

Originally Posted by pavan7

Thanks for responding the script seems not to throw any error but somehow its skipping this part of the code... I am working on it

It's not being skipped, putting the 'bash whatever' just doesn't actually do anything. Take a look at the subprocess module.