[SOLVED] how to make a messy sprintf function work

smeezekitty · 10-03-2009, 01:45 AM

ok, i am writing my own kernel and
i am writing my own version of sprintf
but its not working quite right and i dont know why
i know its mess buy

Code:

int sprintf(char *out, const char *format, ...){
int x;
char val[32];
va_list va;
va_start(va, format);
int ticker = 0;
int ptr = 0;
while(format[ticker]){
if(format[ticker] != '%'){out[ptr] = format[ticker]; ticker++; ptr++;}
else {
ticker++;
out[ptr] = 0;
switch(format[ticker]){
case 'c':
x = va_arg(va, char);
out[ptr] = x;
ptr++;break;
case 's':
strcat(out, va_arg(va, char *));
ptr = strlen(out) + 1;
break;
case 'd':
case 'i':
case 'f':
case 'u':
x = va_arg(va, int);
itoa(x, val, 10);
strcat(out, val);
ptr = strlen(out)+1;
break;
case '%':
out[ptr] ='%';
ptr++;
break;
case 'X':
case 'x':
x = va_arg(va, int);
itoa(x, val, 16);
strcat(out, val);
ptr = strlen(out)+1;
break;
default:break;
}
ticker++;
}
}
out[ptr] = 0;
va_end(ap);
return ptr;
}

smeezekitty · 10-03-2009, 01:47 AM

on an unrelated question can GCC make 16bit code?

ta0kira · 10-03-2009, 01:59 AM

Why do you set ptr to one past \0 for formats other than %c and %%?
Kevin Barry

smeezekitty · 10-03-2009, 02:19 AM

i am alittle confused could you point it out in the code?

ta0kira · 10-03-2009, 02:28 AM

Quote:

Originally Posted by smeezekitty

Code:

case 's':
strcat(out, va_arg(va, char *));
ptr = strlen(out) + 1;
break;

This is in three places. It seems like you should leave off +1: my guess is it causes text falling between two format operations to be overwritten by the second one.
Kevin barry

smeezekitty · 10-03-2009, 02:49 AM

that did it thank you so so so much!
i have been tearing my hair off over this kernel
i promise to release it open source as soon as its done (could be between 2 weeks to 2 months)

lutusp · 10-03-2009, 03:58 AM

Quote:

Originally Posted by smeezekitty

that did it thank you so so so much!
i have been tearing my hair off over this kernel
i promise to release it open source as soon as its done (could be between 2 weeks to 2 months)

This is a joke, right? You're writing the kernel to an operating system, but you don't know how to set pointers yet. Is this a project for a cyber-fiction class, and we're the guinea pigs? Or is this a massive put-on, and the entire episode will be posted to an ironically titled post-modern blog two weeks from now?

Normally a personal learns how to write computer programs, struggles past the usual stage of making dumb mistakes, writes a few major applications, becomes seasoned and efficient, stops trying to program by newsgroup (clearly not so), and then finally, maybe 15-20 years later, takes on OS writing. ... normally.

smeezekitty · 10-03-2009, 11:49 AM

Quote:

Originally Posted by lutusp

This is a joke, right? You're writing the kernel to an operating system, but you don't know how to set pointers yet. Is this a project for a cyber-fiction class, and we're the guinea pigs? Or is this a massive put-on, and the entire episode will be posted to an ironically titled post-modern blog two weeks from now?

Normally a personal learns how to write computer programs, struggles past the usual stage of making dumb mistakes, writes a few major applications, becomes seasoned and efficient, stops trying to program by newsgroup (clearly not so), and then finally, maybe 15-20 years later, takes on OS writing. ... normally.

take your attitude elsewhere