What do people think of my script? Cron runs it daily. I know it needs improvements and error checking, so give me your ideas. Thanks. I know people dont like the automation -y part, so what could go wrong? I want the automation. Lets say apt complained of a dependency problem. Then my script should do something else in that case, or maybe it won't do anything because I did not include --force-yes.
Code:
#!/bin/bash
if [ `whoami` != "root" ]; then
echo "You must be root to execute this script."
exit
fi
apt-get update
apt-get upgrade -y
echo "----------------------------------------------" >> /tmp/mylog
echo "Apt successfully updated the system:" >> /tmp/mylog
echo $(date) >> /tmp/mylog
echo >> /tmp/mylog
apt-history show >> /tmp/mylog
echo >> /tmp/mylog
cat /tmp/mylog | sendEmail -t myemail@gmail.com -f root@mydomain.org -u "Apt successful system update" -q
cat /tmp/mylog | tee -a /var/log/pkgsbyapt
rm -f /tmp/mylog
apt-get clean
exit 0
help improve my script that updates the system by cron
