Please reffer below ::

class Base{

public:
Base(){ printf("Base class condructr invoked\n");}

void execute();

int common();

~Base() { printf("Base detructor\n");}

};


void Base::execute(){



int x=0;


x=common();

printf("%d \n value \n",x);

}


int Base::common(){

int m = 10;

return 10;
}




In the above example code I want to use the execute function of the base class & local variables, this Base class is used in lots of place meant lots of classes have derived this.


Now I want to use this Base class and when execute is callled I wante my common funtion to be called, wanted to know whether
it is feasible to change the base class function name common to virtual<this will not impact any other code>

or to do the following way??


class Derived:: public Base{

public:

virtual int common();
}

int Derived :: common(){

return 20;
}



can I declare function by virtual in the derived class is this accetable??

since I am new to C++ devell.. I i dont want mess up with exising large chunk of code..I hope I above is clear


please do suggest, thanks in advance

I can't figure out what the above phrase means, so I can't understand your question.

But here is an answer in the general area of your question:

If a function is declared virtual in a derived class and not virtual in the base class, any call to that function where the compile time type is the base class (such as any call through a pointer to base class) will use the base class function. Any call where the compile time type is the derived class (or a class further derived from that) will go through the vtable to get the appropriate virtual function for the run time type.

So, if I understand your example correctly, you must change the base class definition of common() to be virtual in order for the base class version of execute() to call the run time type version of common(). Declaring the derived class common() as virtual isn't enough if the base class common isn't virtual and isn't necessary if the base class common is virtual.

This will add a little overhead to all objects of that base class and any derived classes, but it should not change the results for any base class object, nor for any other derived classes that don't declare an override for common().

Thnaks for the reply,

from johnsfine
Quote:
Originally Posted by caruna
wanted to know whether
it is feasible to change the base class function name common to virtual<this will not impact any other code>

I can't figure out what the above phrase means, so I can't understand your question.

Wanted to know, whether the existing functionality will get impacted by changing the base class function to virtual?? I believe it will not get impacted for other code which using this base class.

Thanks...

It will probably not affect other code, particularly if yours is the only class that overrides the common function. If there are no other virtual functions, it will affect the layout of base class objects (which wouldn't be a problem under most circumstances).

However, you do need to be careful that your common code does not omit anything that is required 'by contract' in the original class (either by calling the base class common from the common function in the derived class, or replacing the functionality in the derived class). You also need to determine whether the destructor should also be virtual (this will depend on how the objects are deleted).

You will also need to recompile any code that uses the base class.

You wouldn't simply declare the common function as virtual in the derived class, since the base class will still have a non-virtual common function (I am assuming that your intention is to override common where other code is using a pointer to an object of the base class type).