having problem with typedef

TurtleFace · 03-30-2006, 05:12 PM

i'm trying to debug this solitaire program i wrote but i keep getting errors when i try to reference my typdef statements. i get the following errors:

Quote:

driver.cpp: In function `int main()':
driver.cpp:7: error: invalid conversion from `int' to `Card::suit'
driver.cpp:7: error: initializing argument 1 of `Card::Card(Card::suit, Card::value, Card::status)'
driver.cpp:7: error: invalid conversion from `int' to `Card::value'
driver.cpp:7: error: initializing argument 2 of `Card::Card(Card::suit, Card::value, Card::status)'
driver.cpp:7: error: invalid conversion from `int' to `Card::status'
driver.cpp:7: error: initializing argument 3 of `Card::Card(Card::suit, Card::value, Card::status)'

here is the code

Card.h:

Code:

#ifndef CARD
#define CARD
  
#include <iostream>
#include <string>
using namespace std;

typedef int suit;
typedef int value;
typedef int status;

class Card {  
	public:
		/* Class Constructor
		   pre - Card does not exist
		   post - Card exists with attributes s,v,f */
		Card(suit s, value v, status f);

		/* Copy Constructor
		   pre - original exists and is a Card object
		   post - An exact copy of original is made and returned */
		Card(const Card & original);

		/* Change status of a Card to UP
		   pre - Card exists
		   post - Card.status := FaceUp */
		void FaceUp();

		/* Change status of a Card to DOWN
		   pre - Card exists
		   post - Card.status := FaceDown */
		void FaceDown();

		/* Returns the Status of a Card
		   pre - Card exists
		   post - Card is unchanged; current status of Card is returned to user */
		Status CardStatus() const;

		/* Return the Value of a Card
		   pre - Card exists
		   post - Card is unchanged; current value of Card is returned to user */
		Value CardValue() const;

		/* Return the Suit of a Card
		   pre - Card exists
		   post - Card is unchanged; current suit of Card is returned to user */
		Suit CardSuit() const;

		/* Return the image of a Card
		   pre - Card exists
		   post - Card is unchanged; current image of card is returned to user */
		string CardImage();

		/* Sets the cards output image
		   pre - Card exists
		   post - iamge of the card has been created */
		void SetCardImage();

		/* Overloaded = operator
		   pre - Card exists
		   post - Data members are set equal to those of anotherCard */
		Card & operator = ( const Card & );

	private:
		suit mySuit;
		value myValue;
		status myStatus;
		string image;
	};
#endif

Card.cpp:

Code:

#include "Card.h"

Card::Card(suit s, value v, status f){
	mySuit = s;
	myValue = v;
	myStatus = f;
	SetCardImage();
	}

Card::Card(const Card & original){
	mySuit = original.mySuit;
	myValue = original.myValue;
	myStatus = original.myStatus;
	SetCardImage();
	}
  
void Card::FaceUp(){
	myStatus = 1;
	SetCardImage();
	}
  
void Card::FaceDown(){
	myStatus = 0;
	SetCardImage();
	}

status Card::CardStatus() const {
	return myStatus;
	}

value Card::CardValue() const {
	return myValue;
	}

suit Card::CardSuit() const {
	return mySuit;
	}
  
string Card::CardImage() {
	return image;
	}
  
void Card::SetCardImage() {
	if (CardStatus() == 1) {
		switch (CardValue()) {
			case 0: 	image = " A ";	break;
			case 1: 	image = " 2 ";	break;
			case 2: 	image = " 3 ";	break;
			case 3: 	image = " 4 ";	break;
			case 4: 	image = " 5 ";	break;
			case 5: 	image = " 6 ";	break;
			case 6: 	image = " 7 ";	break;
			case 7: 	image = " 8 ";	break;
			case 8: 	image = " 9 ";	break;
			case 9: 	image = "10 ";	break;
			case 10:	image = " J ";	break;
			case 11:	image = " Q ";	break;
			case 12:	image = " K ";	break;
			}

		switch (CardSuit()) {
			case 0: 	image + "H";	break;
			case 1: 	image + "C";	break;
			case 2: 	image + "D";	break;
			case 3: 	image + "S"; 	break;
			}
		}
	else if (CardStatus() == 0) {
		image = "XXXX" ;
		}
	else {
		image = "NONE" ;
		}
	}

Card & Card::operator = (const Card & anotherCard) {
	myStatus = anotherCard.myStatus;
	myValue = anotherCard.myValue;
	mySuit = anotherCard.mySuit;
	SetCardImage();
	return * this;
	}

driver.cpp:

Code:

#include "Card.h"

int main() {
	Card temp(0, 0, 1);
	cout << temp.CardImage();
	return 0;
	}

i know the problem is something simple i just can't figure it out. all help is appreciated.

cupubboy · 03-30-2006, 05:26 PM

Might me a compiler issue .. I can't see really what's wrong .. I'll try to replicate this behaviour in a minute ..

Also have you considered using enums ? they sound more appropriate

-- Later edit:
You also have an error
remember that your code is case sensitive
you have: typedef int value;

but then you use:
Value CardValue() const;

it should be "value" not "Value" (same thing for Status and Suit in your Card.h)

After modifying Card.h (on my windows box

.. with gcc 3.4.2 (mingw)) .. everything compiled and worked

TurtleFace · 03-30-2006, 06:02 PM

i made the changes but i still get the same errors. so i just have problems with my compiler?

cupubboy · 03-30-2006, 07:12 PM

I think I read somewhere about a certain version of g++ havin problems with typedefs .. but I'm not sure .. what version are you using?

In about one hour or so .. I'll finish here and reboot into linux and also try there .. like I said .. on Windows with gcc 3.4.2 it compiles perfectly after the changes in Card.h

cupubboy · 03-30-2006, 09:18 PM

Update:
I've just compiled it under CentOs 4.2 with g++ (GCC) 3.4.4 20050721 (Red Hat 3.4.4-2) with just the 3 modifications on Card.h