[SOLVED] grep for variable in a bash script

wick_chad · 08-19-2010, 09:28 PM

simple problem, I just cant seem to figure it out.. I've tried every combination of ' " \ that I have come across in similar threads on the forum but no luck..

I have 2 files
strings.txt: contains a list of numbers, 4 digits per line
file.txt: contains a lines that I want to grep for the strings.

for example:
>cat strings.txt
3214
8746
2411

>cat file.txt
freds phone number is 2411
janes phone number is 8746
carls phone number is 3214

this is what I'm using, but it isnt working.

Code:

#!/bin/bash
for i in $`cat strings.txt`; do
   grep "$i"  file.txt
done

if I echo $i in the loop, I print out the contents of strings.txt
If I put 3214 in place of grep "<$i>" file.txt I get "carls phone number is 3214"

but, together, it isnt doing anything...

thanks
-wick

konsolebox · 08-19-2010, 09:38 PM

Code:

grep -F -f strings.txt file.txt

or more precisely:

Code:

grep -f <(sed 's/.*/ &\$/' strings.txt) file.txt

wick_chad · 08-19-2010, 10:00 PM

thanks for the prompt response.

unfortunately I tried that with no luck.. nothing gets outputted

Code:

$ cat strings.txt
5371
5343
5213
5037
5007
4840
4806
$ cat file.txt
andys phone number is  5371
cathys phone number is  5343
janes phone number is  5213
freds phone number is 5037
brads phone number is  5007
$ grep -F -f strings.txt file.txt
$ grep 5371 file.txt
andys phone number is  5371
$ grep -f <(sed 's/.*/ &\$/' strings.txt) file.txt
$

konsolebox · 08-19-2010, 10:08 PM

You sure the files are in UNIX format? The command works fine with me:
strings.txt

Code:

3214
8746
2411

file.txt

Code:

freds phone number is 2411
janes phone number is 8746
carls phone number is 3214

command

Code:

grep -f <(sed 's/.*/ &\$/' strings.txt) file.txt

output

Code:

freds phone number is 2411
janes phone number is 8746
carls phone number is 3214

info: http://kb.iu.edu/data/acux.html

grail · 08-19-2010, 10:17 PM

Gotta back konsolebox, works for me ... I even tried it without the sed and all worked fine:

Code:

grep -f strings.txt file.txt

Obviously the diff is that this mode will allow the strings to appear anywhere, so not as concise but might help for testing.

wick_chad · 08-20-2010, 08:40 AM

Quote:

Originally Posted by konsolebox

You sure the files are in UNIX format? The command works fine with me:

that was it!!
I had created the file strings.txt on a windows PC and saved it to linux.. once I ran dos2unix everything worked. I didnt realize the end of line differences would create a problem..

MUCHAS GRACIAS

grail · 08-20-2010, 10:16 AM

Glad you have your solution, please mark as SOLVED.