[SOLVED] Get strings distributed along up to 3 lines

Perseus · 11-10-2013, 12:36 AM

Hello pan64,

I was able to see what was happening with the incorrect printing of column1. The correct while loop is as below.

Code:

	while ( defined ( my $l = <F> ) ) {
                while (length $l < $MINIMAL_RECORD_LENGTH) {
                    #$l .= $sep; --> This line is not needed
                    $l .= <F>;
                }
		process ($l);
	}

Hello grail,

I was trying to do the same with ruby, but doesn't work in the way below:

Code:

IO.foreach(ARGV[0]){ |l| 
    line = l.unpack('H*')[0]
		
	while line.length < MINIMAL_RECORD_LENGTH do
		line = line + l.unpack('H*')[0]		
	else
                #Original code
	end
} if File.exists?(ARGV[0])

Where and how would be the correct way to insert the while loop in ruby code?

Thanks in advance

pan64 · 11-10-2013, 11:50 AM

Quote:

Originally Posted by Perseus

Hello pan64,

I finally was able to make the comparison in perl in the long way (if.. else) since I was not able to make it short way, since
I don't know how to assign the pattern to a variable. I did like below.

Code:

$z= join ("|", @result[ 3 .. $#result);	

if($z=~/2,13,8147526905,0\|\|\|12,13,8147526905,1,1\|\|12,13,814752695(59|65|86),0\|\|1\|2\|1\|2\|1\|0\|1\|255\|255\|255\|2\|1\|2\|11/)
{
	push @result, "A";
	}
else {
	push @result, "B";
}

In ruby I was able to do it in short way like below:

Code:

z = "|" + [fruit.compact,rest.scan(/../).map{|z| z.hex}].join("|")	
compare=/2,13,8147526905,0\|\|\|12,13,8147526905,1,1\|\|12,13,814752695(59|65|86),0\|\|1\|2\|1\|2\|1\|0\|1\|255\|255\|255\|2\|1\|2\|1/
z = ( z=~ compare ? z . "|A" : z . "|B" )

Thanks in advance.

the perl way is quite similar:

$z .= ( ($z =~ <your regexp>) ? "|A" : "|B" );

The other thing: in this line:
$z= join ("|", @result[ 3 .. $#result);
the closing ] is missing.

About the separator: I think it will be missing (the length of the line will not be the same, but I have not tested, I do not really know if it is required or not).

Perseus · 11-10-2013, 11:58 AM

Hello pan64,

Thank you for your answer. Yes, the "]" is missing, I added.

The issue I had is how to assign that long regex to a variable, similar to how I done in ruby with variable "compare".

If I can assign the regex to a variable, I think could be easiest to use the short way of "if".

Thanks again.

Perseus · 11-10-2013, 11:53 PM

Hello pan64,

Thank you. I was able to store in variable the regex with "$var = qr//" and use the short form of "if".

Hello grail,

The way that worked the suggestion of pan64 in post # 112 is like below:

Code:

while ( defined ( my $l = <F> ) ) {
            while (length $l < $MINIMAL_RECORD_LENGTH) {
                #$l .= $sep; --> This line is not needed
                $l .= <F>;
            }
	process ($l);
}

But I'm still don't know how to apply it to your ruby code, I've tried like below but is failing.

Code:

IO.foreach(ARGV[0]){ |l| 
    line = l.unpack('H*')[0]
		
	while line.length < MINIMAL_RECORD_LENGTH do
		line = line + l.unpack('H*')[0]		
	else
                #Original code here
	end
} if File.exists?(ARGV[0])

Maybe you can help me with this.

Thanks one more time both.

Regards

pan64 · 11-11-2013, 12:25 AM

I would do something like this:

Code:

line = ""
IO.foreach(ARGV[0]){ |l| 
    line = line + l.unpack('H*')[0]
		
	while line.length < MINIMAL_RECORD_LENGTH do
		# go  to next cycle, so do nothing here
	else
                #Original code here
               line = ""   # empty
	end
} if File.exists?(ARGV[0])

grail · 11-11-2013, 02:59 AM

As it is the foreach that feeds the next line / segment I would suggest using the next operator and storing short readings in a temp variable.
Something like:

Code:

IO.foreach(ARGV[0]){ |l| 
    line = l.unpack('H*')[0]

    if line.length < MINIMAL_RECORD_LENGTH
        tmp_l = line
        next
    end

    line = tmp_l + line if ! tmp_l.nil?

You would also need to set it back to nil at the end of the loop

Perseus · 11-11-2013, 11:16 PM

Hello grail/pan64,

Maybe I did wrong something, but I was able only to get it to work in this way.

Code:

tmp_l = ''
IO.foreach(ARGV[0]){ |l| 
    line = l.unpack('H*')[0]

    if line.length < MINIMAL_RECORD_LENGTH
        tmp_l = line
        next
    end

    line = tmp_l + line 
	
	#Original code
	
	tmp_l = ''
} if File.exists?(ARGV[0])

Many thanks for your help again