echo command didn't pipe the output to the msmtp?

shams · 02-28-2013, 03:17 AM

In this php code, echo command didn't pipe the output to the msmtp:

Quote:

<?php
$from = $_POST['from'];
$To = $_POST['To'];
$subject = $_POST['subject'];
$message = $_POST['message'];
$account = $_POST['account'];

ob_start();
echo "Subject:".$subject."\n To:".$To."\n From:". $from."\n\n".$message;
$str = ob_get_contents();
ob_end_clean();

exec("echo $str | msmtp --account=$account -f $from $To");
?>

NevemTeve · 02-28-2013, 08:55 AM

How do you know it? How did you check the return codes / error-messages? Did you test it with redirection to file, eg:

Code:

exec ("echo $str >testfile");

And do you know how dangerous it is? what if $_POST['from']=`rm -rf ~`

mina86 · 02-28-2013, 09:34 AM

You are doing it wrong since you're inviting everyone to destroy your machine by simple HTTP request (as per NevemTeve's comment). Use popen instead and write directly to the pipe. No output buffering needed.

NevemTeve · 02-28-2013, 10:26 AM

Note: If you want it this way (not recommended), then it would be something like this:

Code:

<?php
    $from = $_POST['from'];
    $To = $_POST['To'];
    $subject = $_POST['subject'];
    $message = $_POST['message'];
    $account = $_POST['account'];

    $str= sprintf ("Subject: %s\nTo:%s\nFrom: %s\n\n%s",
        $subject, $To, $from, $message);
    putenv ("str=".$str);
    putenv ("from=".$from);
    putenv ("to=".$To);
    putenv ("account=".$account);

    exec ('echo "$str" | msmtp --account="$account" -f "$from" "$To"');
?>

shams · 02-28-2013, 11:28 AM

Thanks for replies and suggestions the code of NevemTeve worked perfect, i will also try the popen but i need to read a lot because i don't have enough knowlegde about coding, i only copy the codes and make the new one for my use.

shams · 03-01-2013, 01:47 AM

I added the $Date variable to the above code but print the wrong date in the email headers, the system date is correct:

Quote:

$Date='$(date +%Y-%m-%d-%H:%M:%S %UT)';

NevemTeve · 03-01-2013, 02:19 AM

It doesn't seem to be valid PHP code...

Code:

    $tm = time ();
    $date = date ('Y-m-d-H:i:s', $tm);
    printf ("now is %s\n", $date);

http://www.php.net/manual/en/function.date.php

shams · 03-01-2013, 08:21 PM

Thanks for the reply, the above date code work fine alone but whein i added to the mail header still print the wrong time:

Quote:

<?php
$From = $_POST['From'];
$To = $_POST['To'];
$Subject = $_POST['Subject'];
$Body = $_POST['Body'];
$account = $_POST['account'];
$tm = time ();
$Date = date ('Y-m-d-H:i:s', $tm);

$str= sprintf ("Subject: %s\nTo:%s\nFrom:%s\nDate: %s\n\n%s",
$Subject, $To, $From, $Date, $Body);
putenv ("str=".$str);
putenv ("From=".$From);
putenv ("To=".$To);
putenv ("account=".$account);
putenv ("Date=.$Date");

exec ('echo "$str" | msmtp --account="$account" -f "$From" "$To"');
echo '<b>Message Sent, thank you</b>';

?>

This is the time was print in the email header:

Quote:

Date: Thu, 01 Jan 1970 04:30:00 +0430 (Unknown)

NevemTeve · 03-01-2013, 11:10 PM

You should read the documentation to find out the expected date format, and implement that with PHP's date function.