cleaner loop in php

pcock · 05-01-2009, 12:48 AM

Can someone help show me a cleaner way to do this please

Code:

<?php
// date menu
echo '<select name="date_part">'."\n";
$i = 1;
$ii = 1;
while ($i <= 31)
{
$date_menu .= '<option value="'.$i++ .'">';
$date_menu .= $ii++ .'</option>'."\n";
}
echo $date_menu;
echo '</select>';
?>

Acron_0248 · 05-01-2009, 01:56 AM

The only thing that I would change is that $ii variable since it doesn't make sense

PHP Code:


			
$i = 1;

while ($i <= 31)

{

    $date_menu .= "<option value=\"$i\">$i</option>\n";

    $i++;

}



echo '<select name="date_part">'."\n";



echo $date_menu;



echo '</select>';

The same output can also be obtained using sightly different code so I think is more a matter of taste =)

aspire1 · 05-01-2009, 07:44 AM

Can't really add much myself, apart from when I was learning programming it was drummed into us if you know how many times a loop is going to iterate use a for loop but I don't think it's a law or anything, you won't get arrested

delite · 05-01-2009, 09:37 AM

Code:

for($i=1;;$i++)

actually I forgot about the clause:

Code:

for($i=1;$i<=32;$i++)

haxple · 05-02-2009, 01:59 PM

This gives you the exact same output

PHP Code:


			
<?php
echo '<select name="date_part">'."\n";
for ($i=1;$i<=31;$i++)
    echo '<option value="'. $i .'">'. $i .'</option>'."\n";
echo '</select>';
?>