Bash script with sed

hadarg · 03-07-2015, 10:06 AM

Hi,
I wrote a script with 3 parameters: adduser, searchuser and deleteuser and for some weird reason the deleteuser doesn't work. can someone assist me with this problem?

Thanks!!

function deleteuser ()
{
if grep -q "$1" "$usersfile"; then
sed -i '/$1/d' "$usersfile"
echo $?
echo "User was deleted"
return
else
echo "User wasn't found"
return
fi
}

teckk · 03-07-2015, 03:52 PM

How about

Code:

delete_user () {
	grep -q "$1" "$usersfile"
		if [ $? -eq 0 ]; then
			sed -i '/$1/d' "$usersfile"
			echo "User was deleted"
			else 
			echo "User wasn't found"
		fi
	return
}

grail · 03-08-2015, 07:20 AM

Firstly, no need to use $? as suggested as the current solution already has 'if' do that.

Your function uses $1 and $usersfile, where is the second being set as it is not done in the function?

Also, no need to return twice (if at all).

Finally, would you explain what - deleteuser doesn't work - means? This is an ambiguous statement. Also, have you isolated this function into a script on it own and tested it?

rtmistler · 03-10-2015, 07:47 AM

A good thing to add to this is to enable debugging within your script, "set -xv" at the top of your script, but below the #!/bin/sh line will turn on verbose output and show you the actions and decisions made as your script runs. It will help you to debug things.