Bash Script for eenaming Multiple files

vk4led · 09-01-2013, 08:46 PM

G'day

I am trying to get a script working that will copy existing files (most do no have an extension) to another folder and append all files with the extension .txt

I have the cp command down pat (cp /existing_folder /new_folder)

however I am stuck on the rename part. I have had some help with suggestions in getting some scripting down in order to rename files that dont have extension and move them to another folder (code below)

Code:

SOURCE_DIR="/home/webstuff"
TARGET_DIR="/home/webstuff/trial"

for SF in $SOURCE_DIR/*
do
  case `basename "$SF"` in
    *.* )  
      # Has an extension
      TF=$SF
      ;;
  * )
      # Does not have an extension
      TF="$SF.txt"
      ;;
  esac

  cp $SOURCE_DIR/$SF $TARGET_DIR/$TF
  if [[ $? -eq 0 ]]; then
    echo "Successfully copied $SOURCE_DIR/$SF to $TARGET_DIR/$TF"
  else
    echo "$? : Error occured coping $SOURCE_DIR/$SF to $TARGET_DIR/$TF"
  fi
done

however it is spitting out the following:

Quote:

cp: cannot stat `/home/webstuff//home/webstuff/setMonDate': No such file or directory

1 : Error occured coping /home/webstuff//home/webstuff/weboutput to /home/webstuff/trial//home/webstuff/weboutput.txt

To me this is a problem with the copying of the files? Maybe a double copy??

The files do exist in the SOURCE_DIR="/home/irlp/webstuff" dir

I am seeking suggestions in getting the bash script working (Debian System)

Most files do not have an extension (they are scripts) and some do (eg .conf)

I am hoping to copy the files to a specific folder, append them with .txt and make them viewable for other on the web.

Hope that makes sense and I appreciate your input

evo2 · 09-01-2013, 10:23 PM

Hi,

I can see two problems:

1. When setting the TF you need to strip the $SOURCE_DIR path from $SF.
Use the following (assuming bash) to set TF:

Code:

TF="${SF##*/}"

or if adding .txt

Code:

TF="${SF##*/}.txt"

2. When calling cp you should be using just $SF instead of $SOURCE_DIR/$SF
Use the following

Code:

cp "$SF" "$TARGET_DIR/$TF"

Also, it is best to quote your variables (eg "$SF" instead of $SF)... consider what might happen if your filenames contained spaces.

HTH,

Evo2.

vk4led · 09-01-2013, 10:28 PM

Many thanks for the reply

I will pop the amendments into the script soon and give it a run

I will report back on the findings

Thanks again

evo2 · 09-01-2013, 11:55 PM

Hi,

I just noticed that you are using the basename command. The ${SF##*/} does basically the same thing but without the need to call and external executable.

Cheers,

Evo2.

vk4led · 09-02-2013, 04:39 AM

Many thanks for your help. The script now works well.

Appreciate the input and assistance

mina86 · 09-02-2013, 06:53 AM

PS. To get into good habits, the for line should looks as follows:

Code:

for SF in "$SOURCE_DIR"/*

konsolebox · 09-02-2013, 10:18 AM

There's no need to call basename too:

Code:

#!/bin/bash

SOURCE_DIR="/home/webstuff"
TARGET_DIR="/home/webstuff/trial"

for SF in "$SOURCE_DIR"/*; do
  TF=${SF##*/}
  [[ $TF != *.* ]] && TF=$TF.txt
  TF=$TARGET_DIR/$TF
  cp "$SF" "$TF"
  if [[ $? -eq 0 ]]; then
    echo "Successfully copied $SF to $TF."
  else
    echo "$? : Error occurred copying $SF to $TF."
  fi
done

grail · 09-02-2013, 07:40 PM

You could shorten even a little further as the use of $? is not required when 'if' can already test the return code:

Code:

if cp "$SF" "$TF"; then

Using konsolebox's code as example.

Firerat · 09-02-2013, 09:45 PM

Alternate
http://www.tldp.org/LDP/abs/html/lis...ml#LISTCONSREF

Code:

cp "$SF" "$TF" && echo "Successfully copied $SF to $TF." \
               || echo "$? : Error occurred copying $SF to $TF." >&2

note the >&2, it is sending output to stderr.. just for fun