bash issue with sed command not running under cron. could be whole script

DirtyHowi · 08-12-2014, 12:04 PM

i'm trying to get something that runs fine at the command line to run via cron and it don't. which is not unusual.

Code:

  1 #!/bin/bash
  2 cd /data1/mylx08/disk65/WEBSVC-XTRACT/
  3 find . -type f -name '*.err' -mmin +5  | while read filename; do mv -v "${filename}" "`echo "${filename}" | sed -e 's/\.err$/\.deb/'`";done

I'm not sure how to extricate the sed command from the while loop to get it to run the way it should.

all i'm trying to do is replace the .err with .deb if the file is more than 5 minutes old, any other suggestions more than welcome.

Firerat · 08-12-2014, 12:09 PM

set PATH env in script, or use full path

/bin/sed

DirtyHowi · 08-12-2014, 12:16 PM

tried that, at least its not deleting the files now. thought maybe the echo command was messing up cron since it runs in the background

DirtyHowi · 08-12-2014, 12:28 PM

all its doing is deleting the file, its not renaming it like it does when run manually

szboardstretcher · 08-12-2014, 12:31 PM

I would just use find and bash:

Code:

find . -type f -name '*.err' -mmin +5 -exec bash -c 'mv $0 ${0/.err/.deb}' {} \;

Meaning, in your crontab:

Code:

*/5 * * * * find /data1/mylx08/disk65/WEBSVC-XTRACT/ -type f -name '*.err' -mmin +5 -exec bash -c 'mv $0 ${0/.err/.deb}' {} \;

No need for a script to do this.

DirtyHowi · 08-12-2014, 12:49 PM

trying now

DirtyHowi · 08-12-2014, 12:55 PM

@szboardstretcher BRILLIANT. thank you sir.

NevemTeve · 08-12-2014, 02:20 PM

Whenever your script fails to work, use logging to find the bug:

Code:

#!/bin/sh

exec >/tmp/$$.log 2>&1

set -xv

do_some_thing

check <pid>.log files in /tmp

szboardstretcher · 08-12-2014, 02:29 PM

Or use this shebang for bash:

Code:

#!/bin/bash -x