bash for + find problem

kule · 02-21-2005, 10:57 PM

I made a script that changes ownership and chmod of files and dirs in a folder from which I execute it. Here is the script:

Code:

#!/bin/bash
#

EXECMOD=700
FILEMOD=600
USER=root
GROUPE=root

for FILE in $( find . )
    do
    #Change ownerships
    chown -v $USER:$GROUPE "$FILE"

    #Give folders exec mod
    if [ -d "$FILE" ]
        then
        chmod -v $EXECMOD "$FILE"

    #If file is a bash script give it exec mod
    elif head -n 1 "$FILE" | grep "#!/bin/bash" 1>/dev/null || head -n 1 "$FILE" | grep "#!/bin/sh" 1>/dev/null
        then
        chmod -v $EXECMOD "$FILE"

    #If file ends with *.sh, *.csr, *.bin or starts with rc.*, give exec mod
    elif [ -f "$FILE" ] && echo "$FILE" | grep *.sh 1>/dev/null || echo "$FILE" | grep *.csh 1>/dev/null || echo "$FILE" | grep *.bin 1>/dev/null || echo "$FILE" | grep rc.* 1>/dev/null
        then
        chmod -v $EXECMOD "$FILE"

    #Else give plain (noexec)  mod
    else
        chmod -v $FILEMOD "$FILE"
    fi
    done

My problem is that when "find" finds a file which has a space in its filename, var $FILE becomes part of the filename and not the whole name of a file, for example:

find found:
U2 - Bad.mp3

$FILE="U2", then $FILE="-" and $FILE=Bad.mp3 and it should be $FILE="U2 - Bad.mp3".

Is there a way this could be done? Or do you have a better idea for my script

jlliagre · 02-21-2005, 11:11 PM

Code:

find . | read FILE
do
...
done

kule · 02-22-2005, 04:40 AM

I don't know how to put that into a loop.
And I think that doesn't work.

jlliagre · 02-22-2005, 05:47 AM

Quote:

I don't know how to put that into a loop.

That way (sorry I missed the while in my previous reply):

Code:

find . | while read file
do
...
done

Quote:

And I think that doesn't work.

Well, you should as it does ...

kule · 02-22-2005, 09:14 AM

I'll try it. Thanks in advance.

kule · 02-22-2005, 11:08 AM

It doesn't work, it works same as:

for FILE in $( find . )

it splits the filename into parts if there is a space in it

Hko · 02-22-2005, 11:45 AM

Quote:

Originally posted by kule
It doesn't work, it works same as:

for FILE in $( find . )

it splits the filename into parts if there is a space in it

Creating test files:

Code:

mkdir test
cd test
touch aaa
touch bbb
touch "ccc ddd"
touch eee

Run shell code:

Code:

find .  | while read file ; do  echo $file; done

Output:

Code:

.
./aaa
./bbb
./ccc ddd
./eee

Seems you were wrong...

jlliagre · 02-22-2005, 02:50 PM

Thanks for your support, Hko

kule · 02-22-2005, 06:19 PM

well it didn't work for me... because I had:

Code:

find .  | while read file ; do chmod 644 $file; done

and not echo, but it worked when I put "" between $file:

Code:

find .  | while read file ; do chmod 644 "$file"; done

Thanks for help.

jlliagre · 02-23-2005, 04:48 AM

Okay, your initial script had not this bug, thus the confusion.