Simple Script Question.

Tadaen · 12-15-2013, 03:58 PM

Will a script only call the next "command" after the previous one is completed? Or will it just run them 1 after the other with no let up?

Was going to build a script to install makemkv and handbrake for me all in one shot.

MS3FGX · 12-15-2013, 04:00 PM

Unless you put a line into the background (with &), then it will wait for each line to finish before going onto the next.

Tadaen · 12-15-2013, 04:03 PM

More explanation... Beginning of script would contain an #apt-get (bunch of stuff here)

Would it wait for that to finish before moving on?

jailbait · 12-15-2013, 04:33 PM

"More explanation... Beginning of script would contain an #apt-get (bunch of stuff here)

Would it wait for that to finish before moving on?"

yes.

----------------------
Steve Stites

David Triebwasser · 12-15-2013, 05:27 PM

There are some cases where you want the script to process in order, completing one task before moving onto others. In other cases you may want to run a sub task in the background and even allow it to run outside of your shell session. There's a good explaination of this more complex process here:
http://stackoverflow.com/questions/1...ch-the-session

Tadaen · 12-15-2013, 06:25 PM

Think I've got what I'm trying to do. Feedback would be appreciated on where I can improve.

Code:

#!/bin/bash
#Install script for MakeMKV & Handbrake
#Run as root!

#Jason
#2013/12/15	3:08 pm

#####Begin Script#####

#Variables#

MKVUSER=me	#user where files located#
MKVPATH=/home/$MKVUSER/Debian/MakeMKV
MKVOSS=makemkv-oss-1.8.7
MKVBIN=makemkv-bin-1.8.7
HB=hb-trunk

clear

echo "Beginning Compilation & Install"
sleep 2

#get deps#

apt-get install -y libc6-dev libssl-dev libexpat1-dev libavcodec-dev libgl1-mesa-dev libqt4-dev ffmpeg pkg-config build-essential subversion yasm build-essential autoconf libtool zlib1g-dev libbz2-dev libogg-dev libtheora-dev libvorbis-dev libsamplerate-dev libxml2-dev libfribidi-dev libfreetype6-dev libfontconfig1-dev libass-dev intltool libglib2.0-dev libdbus-glib-1-dev libgtk2.0-dev libgudev-1.0-dev libwebkit-dev libnotify-dev libgstreamer0.10-dev libgstreamer-plugins-base0.10-dev libappindicator-dev
sleep 2

#oss build & install#

echo "Building MakeMKV OSS Package"
sleep 2
cd $MKVPATH/$MKVOSS
./configure
sleep 1
make
sleep 1
make install
cd ..

#bin build & install#

echo "Building MakeMKV Bin Package"
sleep 2
cd $MKVPATH/$MKVBIN
sleep 1
make
sleep 1
make install
cd ..

#handbrake

echo "Building Handbrake"
sleep 2
cd $MKVPATH/$HB
sleep 1
./configure --enable-ff-mpeg2 --enable-fdk-aac --arch=x86_64 --optimize=speed
cd build
sleep 1
make
sleep 1
make install

#closing notes#

echo "MakeMKV & Handbrake installed. Remember to create a .desktop file for Handbrake"
sleep 4
exit

And made this one to create a shortcut file in the menus.

Code:

#!/bin/bash
#Create Handbrake Launcher	
#Run as user!

#Jason Gibson
#2013/12/15	4:32 pm

#####Begin Script#####

#Variables#

HBUSER=jason
SCPATH=/home/$HBUSER/Desktop/test.desktop
ICONPATH=/home/$HBUSER/Pictures/Icons/Tux.png
APPNAME=Handbrake
APPTYPE=Application
EXEC=ghb
CATEGORY=AudioVideo;
ENCODE=UTF-8
COMMENT=Transcoder

echo "Creating launcher in ~/Desktop"

echo "[Desktop Entry]
Encoding=$ENCODE
Name=$APPNAME
GenericName=$APPNAME
Comment=$COMMENT
Type=$APPTYPE
Exec=$EXEC
Icon=$ICONPATH
Categories=$CATEGORY
Name[fr_FR]=$APPNAME" > $SCPATH

chmod 700 $TESTPATH
mkdir -p /home/$HBUSER/.local/share/applications
cd /home/$HBUSER/.local/share/applications
ln -s $SCPATH

#closing notes#

echo "Shortcut created and added. Enjoy Handbrake!"

These are my first real attempts at scripting.

ondoho · 12-15-2013, 06:59 PM

there's no need for the sleep commands.

Tadaen · 12-15-2013, 07:09 PM

Removed the sleeps, combined the 2 scripts. Had to modify a couple variables to work across the board. Also added more comments for myself so I don't forget how this works. Testing it in a VM right now, internet is slow so still waiting for the package downloads right now.

yooden · 12-16-2013, 03:34 AM

Quote:

Originally Posted by Tadaen

Feedback would be appreciated on where I can improve.

If they work, you are fine. Some minor points:

I would recommend that you never use bash scripts unless you have a reason to. Use Bourne Shell (sh) instead.
Avoid clear(1) and similar commands that mess up the user's screen.
Check certain commands for success, eg. the cd's. If they fail, you might end up with something unexpected.
The combination of cd $var and cd .. seems to be a mismatch.

pan64 · 12-16-2013, 04:16 AM

additionally avoid compiling-building by root (only apt-get and make install should be executed by root)!