faad compile problem make not working

dtra · 04-17-2005, 10:30 PM

hi all

just downloaded faad2-2.0
ran configure with --with-drm --with-mp4v2 (also just ran configure straight)
seemed to run fine, but when i try to run make i get this
Makefile:447: *** missing separator. Stop.

can anyone help me, i am a linux novice
using redhat 9 with bash

thanks
dave

jong357 · 04-17-2005, 10:53 PM

Yea... Minor annoyance.... I could tell you straight up what to do but I have a fettish with patches...

Code:

--- faad2.orig/Makefile.in	2005-04-12 23:30:45.000000000 -0400
+++ faad2/Makefile.in	2005-04-12 23:33:09.841198120 -0400
@@ -607,10 +607,10 @@
 	tags tags-recursive uninstall uninstall-am uninstall-info-am
 
 
-rpm:    Makefile
-       make dist
-       $(RPMBUILD) -ta $(PACKAGE)-$(VERSION).tar.gz
-       rm $(PACKAGE)-$(VERSION).tar.gz
+#rpm:    Makefile
+#       make dist
+#       $(RPMBUILD) -ta $(PACKAGE)-$(VERSION).tar.gz
+#       rm $(PACKAGE)-$(VERSION).tar.gz
 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.
 .NOEXPORT:

Copy all of that into a text file and name it "faad2-fix.patch". Then put it into a freshly un-tared faad2 directory.

cd faad2
patch -Np1 -i faad2-fix.patch

Then run your configure like you normally do. Add --with-xmms and you'll get an .mp4/.m4a plugin for xmms...

Nice thing to have...

jong357 · 04-17-2005, 11:04 PM

And, to kill 2 birds with one stone for future people running GCC 3.4.x, you need this one as well....

Code:

--- faad2.orig/common/mp4v2/mp4property.h	2003-06-29 18:41:00.000000000 -0400
+++ faad2/common/mp4v2/mp4property.h	2005-04-13 00:28:20.736865472 -0400
@@ -58,7 +58,7 @@
 		return m_name;

 	}

 

-	virtual MP4PropertyType GetType() = NULL; 

+	virtual MP4PropertyType GetType() = 0; 

 

 	bool IsReadOnly() {

 		return m_readOnly;

@@ -74,17 +74,17 @@
 		m_implicit = value;

 	}

 

-	virtual u_int32_t GetCount() = NULL;

-	virtual void SetCount(u_int32_t count) = NULL;

+	virtual u_int32_t GetCount() = 0;

+	virtual void SetCount(u_int32_t count) = 0;

 

 	virtual void Generate() { /* default is a no-op */ };

 

-	virtual void Read(MP4File* pFile, u_int32_t index = 0) = NULL;

+	virtual void Read(MP4File* pFile, u_int32_t index = 0) = 0;

 

-	virtual void Write(MP4File* pFile, u_int32_t index = 0) = NULL;

+	virtual void Write(MP4File* pFile, u_int32_t index = 0) = 0;

 

 	virtual void Dump(FILE* pFile, u_int8_t indent,

-		bool dumpImplicits, u_int32_t index = 0) = NULL;

+		bool dumpImplicits, u_int32_t index = 0) = 0;

 

 	virtual bool FindProperty(const char* name,

 		MP4Property** ppProperty, u_int32_t* pIndex = NULL);

--- faad2.orig/common/mp4v2/rtphint.h	2003-06-29 18:41:00.000000000 -0400
+++ faad2/common/mp4v2/rtphint.h	2005-04-13 00:47:55.386291616 -0400
@@ -35,8 +35,8 @@
 		return m_pPacket;

 	}

 

-	virtual u_int16_t GetDataSize() = NULL;

-	virtual void GetData(u_int8_t* pDest) = NULL;

+	virtual u_int16_t GetDataSize() = 0;

+	virtual void GetData(u_int8_t* pDest) = 0;

 

 	MP4Track* FindTrackFromRefIndex(u_int8_t refIndex);

You can name that one "gcc-3.4-fix.patch"

dtra · 04-17-2005, 11:51 PM

thanks for your reply

nm, i am not even using the x server so i don't think xmms will be much use
it should all be cool now, thanks again

nirav.jani · 10-05-2005, 04:41 AM

I was searching faad2's official website that is
http://www.audiocoding.com/
but didn't got solutions there, thanx to linuxquestions.org
i got it here.
nirav