Can't execute Bash script.

zbe · 10-17-2008, 07:10 AM

Hello there,

I have a bash script with the following code in it:

Code:

#!/bin/bash
for url in 'cat $1'
do
 wget -c --load-cookies ~/.cookies/rapidshare $url
done

The code is in a file downloader.sh

I ran

Quote:

chmod +x downloader.sh

to make it executable, but whenever I try to run it by typing

Code:

/downloader.sh somefile

it tells me there is no such command or file.

Anyone know whats up?

Cheers,

Zlatan

P.S. I am trying to run the script for the same directory and I am using an Acer Aspire One with the default linux distro (if that holds any relevance).

colucix · 10-17-2008, 07:27 AM

Why the slash at the beginning of the command line? If you mean "run a command from the current directory" you have to put a dot and a slash. That is

Code:

./downloader.sh somefile

where the dot means the current working directory. Moreover, no need of a cat command in the for loop. If you want to loop over the arguments, better doing something like

Code:

for url in "$@"
do
  <commands here>
done

zbe · 10-17-2008, 07:36 AM

"./" works thank you for that! Although I thought I had tried that :s.

the file I'm passing to my script is a list of urls, each on it's own line. 'cat $1' and '$@' aren't working for looping through them. Do you know what I could use?

I don't really know that I'm doing, I just copied the script from some website.

Thank you for your time,

Zlatan.

colucix · 10-17-2008, 07:54 AM

Quote:

Originally Posted by zbe

the file I'm passing to my script is a list of urls, each on it's own line.

Uh, sorry... I was thinking at somefile as the actual file to download.

Quote:

Originally Posted by zbe

'cat $1' and '$@' aren't working for looping through them. Do you know what I could use?

You can try something like

Code:

#!/bin/bash
while read url
do
  echo "$url"
done < somefile

substitute the echo command with the actual wget command. This is just to check if the file is correctly read.

Just an advice: don't accept downloaded scripts "as is" without knowing what they really do. Nor accept suggestions (mine included) without verifying the presence of erroneous or malicious commands. A quick look at the man pages or at the Advanced Bash Scripting Guide should be enough to prevent (intentional or not intentional) damage to your system.

zbe · 10-17-2008, 08:05 AM

Excellent, thank you very much.

Thanks for the warning, I would usually spot something malicious (I'm a programmer, I'm just very new to linux/bash)