syntax error near unexpected token `}'

Chris1969 · 06-16-2013, 09:54 PM

Hello Guys

I am having a problem with a bash script that I am working on, I am practically new to Bash Scripting and been working on this problem for hours and cant figure out what the problem could be.

When I run the script this are the errors I get:

backupscripts.sh: line 57: syntax error near unexpected token `}'
backupscripts.sh: line 57: `}'

Hope you can help me out, thnx.

Here is the script:

PHP Code:



#!/bin/bash 
 
# Author: Chris Navarrete 
# Purpose: Used to backup files and/or directories locally and store remotely 
 
 
# THIS LINES BELOW ARE THE VARIABLES 
 
BACKUPDIR=~/backup 
SCRIPTDIR=~/arespaldar 
BACKUPFILE=/backup.`date +%F`.bz2 
BACKUPHOST=SERVER IP FOR REMOTE BACKUP 
COUNT=`ls $BACKUPDIR | wc -l` 
TRESHOLD=7 
 
 
 
function checkbackupdir() { 
if [ ! -e $BACKUPDIR ] 
then 
 
    echo "Creating Backup Directory because it doesn\'t exist !" 
    mkdir ~/backup 
    COUNT=0 
#    exit 0 
else 
    COUNT=`ls $BACKUPDIR | wc -l` 
fi 
} 
 
 
function backup() { 
if [ $COUNT -le $THRESHOLD ] 
then 
 
     tar -cjvf $BACKUPDIR/$BACKUPFILE $SCRIPTDIR  
     if [ $? !=0 ]; then echo "Poblems Creating Backup File;" 
     scp $BACKUPDIR/$BACKUPFILE $BACKUPHOST: 
     if [ $? !=0 ]; then echo "Problems Copying Backup File to Backup Host" 
fi 
} 
 
checkbackupdir 
backup 
 
#END

cbtshare · 06-16-2013, 10:25 PM

What is line 57 in your script?...also you use of ' ' for functions is antiquated, its best to use $()... Example..

BACKUPFILE=/backup.$(date +%F).bz2

Fix the rest throughout the script.

chrism01 · 06-16-2013, 11:22 PM

Also

Code:

   if [ $? !=0 ]; then echo "Poblems Creating Backup File;" 

# should have spaces around operator, needs a 'fi'.
# uses wrong operator,  [[ ]] better
   if [[ $? -ne 0 ]]; then echo "Poblems Creating Backup File;"  fi

similarly for next 'if...'
http://tldp.org/LDP/Bash-Beginners-G...tml/index.html
http://www.tldp.org/LDP/abs/html/
http://tldp.org/LDP/abs/html/testcon...ml#DBLBRACKETS

Re [[ ]], for numeric comparisons, consider (( ))

Code:

if (( x == 3 ))
then
	echo "x is 3"
else
	echo "no"
fi

Chris1969 · 06-17-2013, 05:03 PM

Hello

Thank you for your quick replies, I have made the changes sugested, now when I run the script I get this error:

backupscripts.sh: line 55: conditional binary operator expected
backupscripts.sh: line 55: syntax error near `!=0'
backupscripts.sh: line 55: ` if [[ $? !=0 ]]; then echo "Problems Copying Backup File to Backup Host;" fi'

This is what shows on line 55 in the Script:

PHP Code:



if [[ $? !=0 ]]; then echo "Problems Copying Backup File to Backup Host;" fi

This is how the Script looks now after the changes made to it:

PHP Code:



 
#!/bin/bash 
 
# Author: Chris Navarrete 
# Date: 16.06.2013 
# Purpose: Used to backup files and/or directories locally and store remotely 
 
 
 
# THIS LINES BELOW ARE THE VARIABLES 
 
BACKUPDIR=~/backup 
SCRIPTDIR=~/arespaldar 
BACKUPFILE=/backup.$(date +%F).bz2 
BACKUPHOST=199.21.112.70 
COUNT=$(ls $BACKUPDIR | wc -l) 
TRESHOLD=7 
 
 
 
function checkbackupdir() { 
if [ ! -e $BACKUPDIR ] 
then 
 
    echo "Creating Backup Directory because it doesn\'t exist !" 
    mkdir ~/backup 
    COUNT=0 
#    exit 0 
else 
    COUNT=$(ls $BACKUPDIR | wc -l) 
fi 
} 
 
 
function backup() { 
if [[ $COUNT -le $THRESHOLD ]] 
then 
 
     tar -cjvf $BACKUPDIR/$BACKUPFILE $SCRIPTDIR  
     if [[ $? -ne 0 ]]; then echo "Poblems Creating Backup File;"  fi 
     scp $BACKUPDIR/$BACKUPFILE $BACKUPHOST: 
     if [[ $? !=0 ]]; then echo "Problems Copying Backup File to Backup Host;" fi 
 
} 
 
checkbackupdir 
backup 
 
#END

Would really apriciate any help, thnx.

cbtshare · 06-17-2013, 06:07 PM

if [[ $? !=0 ]];

Should have a space

If [[ $? != 0 ]]

chrism01 · 06-17-2013, 06:12 PM

Yeah, and as I said, that's the wrong operator anyway; read those links I put above. It should be -ne or use (( )).

Chris1969 · 06-17-2013, 06:18 PM

cbtshare thank you for the quick reply, I made the modification you sugested now line 55 looks like this:

PHP Code:



if [[ $? != 0 ]]; then echo "Problems Copying Backup File to Backup Host;" fi

After running the Script again this is the error I get:

backupscripts.sh: line 57: syntax error near unexpected token `}'
backupscripts.sh: line 57: `}'

In line 57 this is what I have:

PHP Code:

Thnx for the help, any ideas ?

Chris1969 · 06-17-2013, 06:37 PM

chrism01 thank you for the reply, I have corrected the operator from != to -ne

PHP Code:



if [[ $? -ne 0 ]]; then echo "Problems Copying Backup File to Backup Host;" fi

Runned the script again and this is the error I got:

backupscripts.sh: line 57: syntax error near unexpected token `}'
backupscripts.sh: line 57: `}'

This is what it displays in line 57:

PHP Code:

This is how the script looks now:

PHP Code:



#!/bin/bash 
 
# Author: Chris Navarrete 
# Date: 16.06.2013 
# Purpose: Used to backup files and/or directories locally and store remotely 
 
 
# THIS LINES BELOW ARE THE VARIABLES 
 
BACKUPDIR=~/backup 
SCRIPTDIR=~/arespaldar 
BACKUPFILE=/backup.$(date +%F).bz2 
BACKUPHOST=199.21.112.70 
COUNT=$(ls $BACKUPDIR | wc -l) 
TRESHOLD=7 
 
 
 
function checkbackupdir() { 
if [ ! -e $BACKUPDIR ] 
then 
 
    echo "Creating Backup Directory because it doesn\'t exist !" 
    mkdir ~/backup 
    COUNT=0 
#    exit 0 
else 
    COUNT=$(ls $BACKUPDIR | wc -l) 
fi 
} 
 
 
function backup() { 
if [[ $COUNT -le $THRESHOLD ]] 
then 
 
     tar -cjvf $BACKUPDIR/$BACKUPFILE $SCRIPTDIR  
     if [[ $? -ne 0 ]]; then echo "Poblems Creating Backup File;"  fi 
     scp $BACKUPDIR/$BACKUPFILE $BACKUPHOST: 
     if [[ $? -ne 0 ]]; then echo "Problems Copying Backup File to Backup Host;" fi 
 
} 
 
checkbackupdir 
backup 
 
#END

Thnx.

yancek · 06-17-2013, 07:56 PM

Just a guess due to my limited knowledge of bash but, I would put another "fi" just above the last "}" since you have three if statements in the backup function.

cbtshare · 06-17-2013, 08:21 PM

Correct..you need another 'fi' to close the main 'if' of the function backup.

fi
}
Checkbackupdir
Backup

#end

Chris1969 · 06-17-2013, 08:47 PM

I have applied all sugested changes to the Script, now when I run the Script this is the error I get:

PHP Code:



backupscripts.sh: line 34: syntax error near unexpected token `(' 
 
backupscripts.sh: line 34: `foo checkbackupdir () {'

This is line 34:

PHP Code:



foo checkbackupdir () {

This is how the Script looks now with all changes applied to it:

PHP Code:



#!/bin/bash 
 
# Author: Chris Navarrete 
# Date: 16.06.2013 
# Purpose: Used to backup files and/or directories locally and store remotely 
 
 
# THIS LINES BELOW ARE THE VARIABLES 
 
BACKUPDIR=~/backup 
SCRIPTDIR=~/arespaldar 
BACKUPFILE=/backup.$(date +%F).bz2 
BACKUPHOST=199.21.112.70 
COUNT=$(ls $BACKUPDIR | wc -l) 
TRESHOLD=7 
 
 
 
foo checkbackupdir () { 
if [ ! -e "$BACKUPDIR" ] 
then 
 
    echo "Creating Backup Directory because it doesn\'t exist !" 
    mkdir ~/backup 
    COUNT=0 
#    exit 0 
else 
    COUNT=$(ls "$BACKUPDIR" | wc -l) 
fi 
} 
 
 
foo backup () { 
if [[ "$COUNT" -le "$THRESHOLD" ]] 
then 
 
     tar -cjvf "$BACKUPDIR"/"$BACKUPFILE" "$SCRIPTDIR"  
     if [[ $? -ne 0 ]]; then echo "Poblems Creating Backup File;"  fi 
     scp "$BACKUPDIR"/"$BACKUPFILE" "$BACKUPHOST": 
     if [[ $? -ne 0 ]]; then echo "Problems Copying Backup File to Backup Host;" fi 
fi 
} 
 
checkbackupdir 
backup 
 
#END

Any sugestions ? Thnx.

chrism01 · 06-17-2013, 09:00 PM

WTF is 'foo' doing there ??
You should really read those links I gave.
Try this http://www.cyberciti.biz/faq/bash-sh...tion-examples/

FYI, if you add 'set -xv' near the top, it'll show you what the parser is doing

Code:

#!/bin/bash  # good idea to specify this to ensure you get the shell you want
set -xv

cbtshare · 06-17-2013, 09:07 PM

I guess this is home work and you found a script online an modified it to do what you wanted....just read and learn the basics along with that too.

Chris1969 · 06-17-2013, 09:25 PM

cbtshare your last comment is not really constructive, this is not homework and this is not a web script, any ways if you have nothing else to say, please dont come here to increase your posts amount.

goarilla · 06-18-2013, 06:12 AM

Foo is not a keyword, remove it. Either call your function foo or checkbackupdir but spaces are not allowed
in function names.

Some small notes

-ne
-le
-gt
-ge
-eq

are binary arithmetic operators
meaning they need two operators and they need to be integers eg:

$? -eq 0 # valid comparison: both operands are ints
# True: success of previous command, False: error of previous command
$? -eq "lol" # COMPARISON ERROR: operand2 is string (lol) !!!

=
!=

are binary string operators

PIZZA="LARGE" # assignment of PIZZA
"$PIZZA" = "LARGE" # valid comparison: both operands are strings and True
# since the test is successful
"$PIZZA" = 12 # COMPARISON ERROR: operand2 is int (12)

I hope this is clear.