[SOLVED] small bash script

m3phisto · 04-26-2011, 02:25 AM

hi there, i've written a small cript to blank a file. but there seems to be a mistake in line 33.
can someone help me with this?

Code:

#!/bin/bash



 errormail()
 {
        for host in ${mailaddr[@]}; do
                /bin/mail -s "$subject" $host < "$cmd"
        done
echo mail...
 }


node=`/bin/hostname -s`
subject="An Error occured in delAutoresponder.sh on $node"



mailaddr=("xxx.xxx@xxx.at")
subject="An ERROR occured in delAutoresponder.sh"


#file="/var/spool/mail/autoresponder"
file="/gfsdisk/scripts/test"


if [ -f $file ]
  then

    cmd=`true > $file`
    echo $?
    if [$? ne 0]
      then
         errormail
    fi
fi

thx a lot

colucix · 04-26-2011, 02:38 AM

Code:

line 33: if [$? ne 0]

should be

Code:

line 33: if [ $? -ne 0 ]

that is you need spaces to separate the expression from the opening and closing brackets. Moreover the integer comparison operators always begin with a hyphen. Just take in mind that [ is both a bash built-in and a command. You can verify this assertion on your system by means of

Code:

type -a [

This means that the syntax common to all the linux command is applied, that is <command name><space><argument><space><argument>... and so on. This explains the mandatory presence of the spaces. Instead, the closing bracket ] is the mandatory last command argument.

dudeman41465 · 04-26-2011, 02:39 AM

Nevermind, somebody beat me to it,

m3phisto · 04-26-2011, 02:45 AM

thx for your help but i still get the massage

line 33: [0: command not found

colucix · 04-26-2011, 03:03 AM

Quote:

Originally Posted by m3phisto

thx for your help but i still get the massage

line 33: [0: command not found

This still means the same: there is no space between the [ and $?. It should be

Code:

if<space>[<space>$?<space>-ne<space>0<space>]

m3phisto · 04-26-2011, 03:04 AM

thx a lot! it works now.

brownie_cookie · 04-26-2011, 03:17 AM

please mark your thread as solved

grail · 04-26-2011, 04:38 AM

You could also combine your tests too:

Code:

if [[ -f $file ]] && ! : > $file
then
    errormail
fi