[SOLVED] Scripting help wanted (school assignment)

mmmm13 · 12-01-2013, 07:15 PM

The script requires me to write this:

reads and sets the variable M
reads and sets the variable R
reads and sets the variable T
sum M, R, and T in a variable A
Evaluate A to determine if its greater than 2000
if A is greater than 2000, print on the screen "A is over 2000"
if A is less than 2000, print on the screen "A is 2000 or less"

what I have so far:

read M
read R
read T
while "$M" "$R" "$T" = "A"
read A
if [ "$A" > "2000" ]
then
echo "A is over 2000"
else
if [ "$A" < "2000" ]
then
echo "A is 2000 or less"
fi
fi

not sure how to sum M, R, T maybe : A = M + R + T?
And really don't know where to input it...

and I think I have the top portion wrong as well: "$M".....

can someone give me clarity?

SAbhi · 12-01-2013, 07:58 PM

there is no requirement of while here:

Quote:

A=`expr $M + $R + $T`

would be a help.. or you can use "let" to calculate the sum too.

evo2 · 12-01-2013, 08:04 PM

Hi,

if M, R, and T are integers you can let the shell itself do the sum (assuming bash). eg

Code:

A=$((M+R+T))

Also, you should probably be using -lt instead of < and -gt instead of > for your comparison operators.

Evo2.

kbp · 12-01-2013, 08:07 PM

I usually use bc to perform maths on variables but the other options mentioned are equally valid.

mmmm13 · 12-01-2013, 08:12 PM

Quote:

Originally Posted by evo2

Hi,

if M, R, and T are integers you can let the shell itself do the sum (assuming bash). eg

Code:

A=$((M+R+T))

Also, you should probably be using -lt instead of < and -gt instead of > for your comparison operators.

Evo2.

got to use the -gt and -lt. what I don't really understand is the read M, R and T part in the beginning portion of the script...would A=$((M+R+T))give me the sum for variable A?.

sag47 · 12-01-2013, 08:24 PM

Are we to assume this assignment should be in bash as the scripting language?

You should likely tell your user what exactly they're inputting. If you just show a user a blank line they won't know what to do. See the echo man page and look up the -n option.

Code:

man echo
#e.g.
echo -n "Enter a number: "
read input
echo $input

Quote:

Originally Posted by mmmm13

not sure how to sum M, R, T maybe : A = M + R + T?

You're correct it means A = M + R + T. You're not currently doing any arithmetic. Under Compound Commands see the (( expression )) for how to do arithmetic in bash. I'll give you two examples of arithmetic.

Code:

A=1
B=2
((C=A+B))
#or using substitution
C=$((A+B))

Quote:

Originally Posted by mmmm13

if [ "$A" > "2000" ]

You're not using the [ command (also know as /usr/bin/[ and also the test command) correctly. You need to read the man page for the test command and use it properly.

Code:

man test

Hopefully I haven't made it too easy for you but reading the bash manual really would resolve all of the questions you have. I've read it myself many times.

mmmm13 · 12-01-2013, 08:29 PM

Quote:

Originally Posted by sag47

Are we to assume this assignment should be in bash as the scripting language?

You should likely tell your user what exactly they're inputting. If you just show a user a blank line they won't know what to do. See the echo man page and look up the -n option.

Code:

man echo
#e.g.
echo -n "Enter a number: "
read input
echo $input

You're corret it means A = M + R + T. You're not currently doing any arithmatic. Under Compound Commands see the (( expression )) for how to do arithmatic in bash. I'll give you two examples of arithmatic.

Code:

A=1
B=2
((C=A+B))
#or using substitution
C=$((A+B))

You're not using the [ command (also know as /usr/bin/[ and also the test command) correctly. You need to read the man page for the test command and use it properly.

Code:

man test

Hopefully I haven't made it too easy for you but reading the bash manual really would resolve all of the questions you have. I've read it myself many times.

I have figured it out by all the people that posted. I used this:

#!/bin/bash
let M=0
let R=0
let T=0
A=$((M + R + T))
if [ "$A" -gt "2000" ]
then
echo "A is over 2000"
else
if [ "$A" -le "2000" ]
then
echo "A is 2000 or less"
fi
fi

if I change the values for each M, R, and T it gives me the echo that is supposed to be for -gt or -le.

Thank you all for the input.

mmmm13 · 12-01-2013, 08:30 PM

Quote:

Originally Posted by sag47

Are we to assume this assignment should be in bash as the scripting language?

You should likely tell your user what exactly they're inputting. If you just show a user a blank line they won't know what to do. See the echo man page and look up the -n option.

Code:

man echo
#e.g.
echo -n "Enter a number: "
read input
echo $input

You're corret it means A = M + R + T. You're not currently doing any arithmatic. Under Compound Commands see the (( expression )) for how to do arithmatic in bash. I'll give you two examples of arithmatic.

Code:

A=1
B=2
((C=A+B))
#or using substitution
C=$((A+B))

You're not using the [ command (also know as /usr/bin/[ and also the test command) correctly. You need to read the man page for the test command and use it properly.

Code:

man test

Hopefully I haven't made it too easy for you but reading the bash manual really would resolve all of the questions you have. I've read it myself many times.

It was bash, sorry.

sag47 · 12-01-2013, 09:29 PM

Quote:

Originally Posted by mmmm13

#!/bin/bash
let M=0
let R=0
let T=0
A=$((M + R + T))
if [ "$A" -gt "2000" ]
then
echo "A is over 2000"
else
if [ "$A" -le "2000" ]
then
echo "A is 2000 or less"
fi
fi

if I change the values for each M, R, and T it gives me the echo that is supposed to be for -gt or -le.

Thank you all for the input.

Your assignment is still not complete. You need to read and set M/R/T. I gave you an example of how to read and set a variable in my previous post. Also, your use of the last if statement is unnecessary. One would assume that if it's not greater than 2000 then all other cases would be less than or equal to 2000 (with the assumption that it is always a number comparison). In that case only a "if else" is necessary. You should also note the assumption of valid input only from the user.