script won't execute

jazzo · 10-03-2014, 04:17 PM

Hello all,
I have just created the text1.sh script with notepad in ubuntu containing the following code:

Code:

!#/bin/bash
read -p "Enter your name: " name
echo "Hi, $name, let's be friends!"

then I changed the permissions and executed it:

Code:

antobbo@antobbo-linux-Dell-System-XPS-L702X:~/Desktop$ ./test1.sh

but whatever I type at the prompt after I click enter I receive the following message:

Code:

: No such file or directorybash
Enter your name: baost
': not a valid identifier `name
Hi, , let's be friends!
antobbo@antobbo-linux-Dell-System-XPS-L702X:~/Desktop$

I'm kind of wondering what it is that I've done wrong...any idea?
thanks

John VV · 10-03-2014, 04:28 PM

Quote:

created the text1.sh script with notepad

???
Notepad ?
as in Microsoft's Notepad ?

then the FIRST thing you need to do is run
"dos2unix" on it to remove the MICROSOFT line endings

then you will likely need to look at it is gedit,kate,kwrite,vi,emacs,....
to make sure that it is not royally messed up from he Microsoft formatting

michaelk · 10-03-2014, 05:28 PM

And...

Quote:

!#/bin/bash

Should be

Quote:

#!/bin/bash

jazzo · 10-04-2014, 04:57 AM

Thanks guys:
@John VV: no not microsoft, I'm on ubuntu 12.04...but now that you say that, notepad probably runs on wine...um.
@michaelk: thanks for spotting that, apologies, I'll be more careful next time!
SO, I scrapped that file, installed emacs, done the script again and saved with a different name and now it works :-)
thanks guys for your help!

grail · 10-04-2014, 07:44 AM

Please mark as SOLVED once you have a solution

jlinkels · 10-04-2014, 08:12 AM

Notepad saved the file as DOS format with CRLF. Bash doesn't understand that. Next time run dos2unix to clean the file.

jlinkels