[SOLVED] Script to move files with log and email and cron

ellis859 · 01-04-2011, 01:25 PM

Hi,

I'm a newb and I need help please.

A user will be ftping some files to an upload directory. I need to move those files to another directory. I also need to mail a list of the just moved files to the user. This job will need to run every 10 minutes. I need to keep a log that holds all the files for the day that were moved, renaming it with the date/timestamp.

I have this below but I just can't put it all together. Can someone help me make a workable script out of this?

#!/bin/bash
# test.shl
source="/u03/upload/"
dest="/u01/dataload/"
log="/u03/logs/transfer.log"
arch="/u03/logs/transfer_daily.log"

list="ls /u03/transfer/finaid/upload/$1*"
echo $list > /u03/logs/transfer.log
echo $list >> /u03/logs/transfer_daily.log
mv /u03/upload/*.* /u01/dataload/

echo "$list has been copied to dataload directory successsfully" | mail -s "Transfer Complete" user@work.com

#!/bin/bash
# archlog.shl
mv /u03/logs/transfer_daily.log /u03/logs/transfer_daily_`date +"%Y%m%d%H%M%S"`.log

crontab:
10,20,30,40.50,60 00 * * 0-6 /u03/bin/test.shl # runs every 10 minutes
0 2 * * 0-6 /u03/bin/archlog.shl # runs at 2am

Thanks!

chrism01 · 01-04-2011, 06:25 PM

A couple of comments:

1. you want the results of the ls cmd, so use backquotes (`) not "

Code:

list=`ls /u03/transfer/finaid/upload/$1*`

# or use $(...)
list=$(ls /u03/transfer/finaid/upload/$1*)

2. 1st cron cmd runs at midnight only. To run every hour, use the wildcard

Code:

10,20,30,40.50,60 * * * 0-6 /u03/bin/test.shl

grail · 01-05-2011, 01:16 AM

I would also mention that you went to a lot of trouble to create variables in your first script, but then you never use them?
So first script could look like:

Code:

#!/bin/bash
# test.shl

source="/u03/upload/"
dest="/u01/dataload/"
log="/u03/logs/transfer.log"
arch="/u03/logs/transfer_daily.log"

list=( /u03/transfer/finaid/upload/$1* )
echo "${list[*]##*/}" | tee -a $arch > $log

mv ${source}*.* $dest

echo "${list[*]##*/} has been copied to dataload directory successsfully" | mail -s "Transfer Complete" user@work.com

I am also curious as to why the files are being moved from /u03/upload/ but when you echo the files that have been moved you look in /u03/transfer/finaid/upload/$1*
This then raises a second question, you use the parameter $1 but according to your cron job you never pass any arguments to the script:

Code:

10,20,30,40.50,60 00 * * 0-6 /u03/bin/test.shl # runs every 10 minutes

ellis859 · 01-05-2011, 08:55 AM

After some work and help I have the script working.....

#!/bin/bash
# test.shl
source=/u03/upload/
dest=/u01/dataload/
log=/u03/logs/transfer.log
arch=/u03/logs/transfer_daily.log
ls $source > $log
ls $source >> $arch
mv $source/* $dest/
filelist="cat $log"
# echo "$filelist" | mail -s "Transfer Complete" user@work.com
exit

Thanks for your help and I'll change the cron as you suggested.

grail · 01-05-2011, 09:39 AM

Just to be sure, you do know that the following has assigned the string cat along with the data stored in $log:

Code:

filelist="cat $log"

Which would seem to serve no purpose for at least 2 reasons:

1. The same information is already in $source
2. To get the data out of $log and store in variable you need to do the following:

Code:

filelist=$(cat $log)

chrism01 · 01-05-2011, 06:43 PM

Also, you have a typo

Code:

10,20,30,40.50,60 00 * * 0-6 /u03/bin/test.shl

# should read

10,20,30,40,50,60 00 * * 0-6 /u03/bin/test.shl

# or even

0,10,20,30,40,50 0 * * 0-6 /u03/bin/test.shl

# or
*/10 0 * * 0-6 /u03/bin/test.shl

Notes:
1. amended '.' to ',' in time list between 40 & 50
2. normally mins are measuerd from the start of the hr, so 0 instead of 60 for every 10 mins
3. single 0 is sufficient instead of 00
4. */x means every x mins (hrs etc) in the current position http://adminschoice.com/crontab-quic...Crontab%20file