scipt help elif
 

hi can someone please tell me how to intgegrate

current_date=`date +%s`

for i in $( ls ); do
tmp_start=`cat $i | grep '"start":' | cut -f 2 -d " " | cut -f 1 -d ","`
tmp_stop=`cat $i | grep '"stop":' | cut -f 2 -d " " | cut -f 1 -d ","`

check for any current recording
if [ $((tmp_stop)) -gt $((current_date)) -a $((tmp_start)) -lt $((current_date)) ]; then
recording=1
fi
done

as an additional parameter to no suspend in to:

#!/bin/bash
sleep 30
if [ `netstat -t | grep -c ":9982"` -ge 3 ]
then
exit 1
elif [ `netstat -t | grep -c "192.168.0.:microsoft-ds ESTABLISHED"` -ne 0 ]
then
exit 1
else
echo pm-suspend
fi

Thank you

I tried

But get error

Do you want to combine both parts of the sript? Please mention what is your ultimate goal for which you're writing this script? I don't understand the use of definning `date +%s` as curent_date, and is it correct... current_date equal to date +%s ?

It is a suspend script which checks for connections on port 9982 and connections to my windows share before disconnecting.

I am trying to add in a test which checks for an active recording by inserting the relevant section of the other script which does work. I just not sure of the if logic.

Just check this:
Once go through "man test" for better understanding of test conditions & declarations/comparision using test.

-- ADDTION ---
Just below the #!/bin/bash line, add a line, set -xv for debugging. It will give you clear idea by showing line by line output of the script. Later you can remove or # this line.

Please use ***[code][/code]*** tags around your code and data, to preserve the original formatting and to improve readability. Do not use quote tags, bolding, colors, "start/end" lines, or other creative techniques.

1) Clean, consistent formatting makes code readable and more easily debuggable. Be liberal with whitespace; indent all your sub-commands evenly and separate logical sections with empty lines. Never just line everything up on the left edge. Add comments anywhere the code isn't completely obvious (and remember, what seems obvious to you now will not be so a year or so down the line).

2) $(..) is highly recommended over `..`

3)
Don't Read Lines With For, and don't parse ls for filenames or data.

Just use a simple globbing pattern here:

4)
Useless Use Of Cat, and multiple grep/cut commands when a single awk expression would probably do better.

Since the file contents are unknown to me, I can't be sure of the exact solution, but it would probably look something like this:
Also, QUOTE ALL OF YOUR VARIABLE SUBSTITUTIONS. You should never leave the quotes off a parameter expansion unless you explicitly want the resulting string to be word-split by the shell (globbing patterns are also expanded). This is a vitally important concept in scripting, so train yourself to do it correctly now. You can learn about the exceptions later.

http://mywiki.wooledge.org/Arguments
http://mywiki.wooledge.org/WordSplitting
http://mywiki.wooledge.org/Quotes


5)
When using bash or ksh, it's recommended to use [[..]] for string/file tests, and ((..)) for numerical tests. Avoid using the old [..] test unless you specifically need POSIX-style portability.

http://wiki.bash-hackers.org/commands/classictest
http://wiki.bash-hackers.org/syntax/...nal_expression
http://wiki.bash-hackers.org/syntax/arith_expr

And you don't need $((..)) unless you're actually evaluating an expression, BTW.

The above does assume that the variables hold simple integers, however.

Thanks for the tips!

I have it working , I had missed out part of the script, here is the working script:

Here is an eg of the dvr log:

Should/can I still tidy it up as you specified?