hi all,
As i am developing my project in 'C' language under Linux platform and GCC compiler. i have developed a small program to reat text from a file and copy words from the file into an array string and then after some comparision i wirte this string into another file. the program is compiled succesfullt but unable to run as it is giving error of SEGMENTATION FAULT all the time. i am not getting where the problem is in my program and how to solve it? i am sending my code to the forum as mentioned under:

Code:
#include <stdio.h>
#include <string.h>
#include <ctype.h>
#include <stdlib.ain()
{
int i,j,x;
FILE *fp1, *fp2;

char c, pos[10], word[50];
fp1 = fopen("new.txt", "r");
fp2 = fopen("masterlistnoun", "w");
if(fp1==NULL)
{ printf("File cannot open\n ");
exit(1);
}
c = getc(fp1);

/* Check for noun tags */
while((c=getc(fp1))!=EOF)
{ i=0;
while(c!='/')
{ word[i++]=c;
c=getc(fp1);
}
word[i]='\0';
j=0;
c=getc(fp1);
while(c!=',')
{ pos[j++]=c;
c=getc(fp1);
}
pos[j]='\0';
if(strcmp(pos, "NNPS")==0 || strcmp(pos, "NN")==0 || strcmp(pos, "NNS")==0 || strcmp(pos, "NNP")==0)
printf(fp2, "%s", word);
putc(' ' ,fp2);
}//outer loop
fclose(fp1);
fclose(fp2);
return 0;
}


**********************************************************************

my input file consist of following text as it is a simple text file:
I/PRP am/VBP Manju/NNP ./.
this/DT is/VBZ a/DT university/NN ./.

my output file is also a text file and totally blank:

***********************************************************************
i will be greatfull if someone solves or suggest somthing to solve the problem. my work is hanged for last three days.

thanks,
Best

Is this just a function to a larger program otherwise i would ask where the main is ?


c = getc(fp1); //Why is this being done ?

/* Check for noun tags */
while((c=getc(fp1))!=EOF) //the above is overwritten here ?
{ i=0;
while(c!='/')
{ word[i++]=c;
c=getc(fp1);
}

Well, this 'DT university' is >10 chars long, so you're writing off the end of pos. (I think)

The first bug that leaps out as I look at the code:

The input you quoted has no ',' in it, so the above loop would read the rest of the file, then read EOF over and over again, until it has exceeded the allocated size of pos[] far enough to cause an access violation.

If there was a ',' and the outer loop worked, then the fact that the input file doesn't end exactly on a ',' could make the previous inner loop overwrite word[].

Also, are you taking newlines into account when reading the input?

File output is buffered, so even if there was a ',' in the input and the code went past the printf (which should have been fprintf) the access violation would still stop the buffered output from reaching the file.

you should start putting printf statements in your code. The text in the printf statements will appear on the console until the segfault occurs. This will let you narrow down where your problem is exactly.

edit: Also this question belongs in the programming forum, and I expect that the first mod to see it will move it.